Re: [PR] Optimize startup time for parallel tests [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #40388:
URL: https://github.com/apache/airflow/pull/40388#discussion_r1649954379


##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -153,14 +153,11 @@ def _run_test(
     shell_params: ShellParams,
     extra_pytest_args: tuple,
     python_version: str,
-    db_reset: bool,
     output: Output | None,
     test_timeout: int,
     output_outside_the_group: bool = False,
     skip_docker_compose_down: bool = False,
 ) -> tuple[int, str]:
-    shell_params.run_tests = True

Review Comment:
   Turned out that those shell_params should be set in "shell_params" outside - otherwise they were missing in `docker pull` and cache envs did not contain RUN_TESTS and DB_RESET set to True.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org