You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Manikumar Reddy O <ma...@gmail.com> on 2015/02/09 19:37:41 UTC
Review Request 30801: Patch for KAFKA-1758
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1758
https://issues.apache.org/jira/browse/KAFKA-1758
Repository: kafka
Description
-------
handled NumberFormatException while reading recovery-point-offset-checkpoint file
Diffs
-----
core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
Diff: https://reviews.apache.org/r/30801/diff/
Testing
-------
Thanks,
Manikumar Reddy O
Re: Review Request 30801: Patch for KAFKA-1758
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/
-----------------------------------------------------------
(Updated May 9, 2015, 7:02 a.m.)
Review request for kafka.
Bugs: KAFKA-1758
https://issues.apache.org/jira/browse/KAFKA-1758
Repository: kafka
Description (updated)
-------
Addressing Neha's comments
Diffs (updated)
-----
core/src/main/scala/kafka/log/LogManager.scala e781ebac2677ebb22e0c1fef0cf7e5ad57c74ea4
Diff: https://reviews.apache.org/r/30801/diff/
Testing
-------
Thanks,
Manikumar Reddy O
Re: Review Request 30801: Patch for KAFKA-1758
Posted by Manikumar Reddy O <ma...@gmail.com>.
> On April 26, 2015, 6:53 p.m., Neha Narkhede wrote:
> > core/src/main/scala/kafka/log/LogManager.scala, line 133
> > <https://reviews.apache.org/r/30801/diff/1/?file=858786#file858786line133>
> >
> > Is there a reason we are limiting this to only NumberFormatException? Seems like a fix that applies to all errors.
> >
> > Also, worth changing the error message to a more generic statement about the problem and the fix (resetting the recovery checkpoint to 0).
Yes, we can catch other exceptions also. updated the log message.
- Manikumar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/#review81622
-----------------------------------------------------------
On May 9, 2015, 7:02 a.m., Manikumar Reddy O wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30801/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 7:02 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1758
> https://issues.apache.org/jira/browse/KAFKA-1758
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressing Neha's comments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogManager.scala e781ebac2677ebb22e0c1fef0cf7e5ad57c74ea4
>
> Diff: https://reviews.apache.org/r/30801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Manikumar Reddy O
>
>
Re: Review Request 30801: Patch for KAFKA-1758
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/#review81622
-----------------------------------------------------------
core/src/main/scala/kafka/log/LogManager.scala
<https://reviews.apache.org/r/30801/#comment132061>
Is there a reason we are limiting this to only NumberFormatException? Seems like a fix that applies to all errors.
Also, worth changing the error message to a more generic statement about the problem and the fix (resetting the recovery checkpoint to 0).
- Neha Narkhede
On Feb. 9, 2015, 6:37 p.m., Manikumar Reddy O wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30801/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2015, 6:37 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1758
> https://issues.apache.org/jira/browse/KAFKA-1758
>
>
> Repository: kafka
>
>
> Description
> -------
>
> handled NumberFormatException while reading recovery-point-offset-checkpoint file
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d
>
> Diff: https://reviews.apache.org/r/30801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Manikumar Reddy O
>
>