You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/04/30 22:39:04 UTC

[GitHub] [phoenix] BinShi-SecularBird commented on a change in pull request #496: Fix slotSpan appending to schema issue in scanRanges.getRowKeyRanges()

BinShi-SecularBird commented on a change in pull request #496: Fix slotSpan appending to schema issue in scanRanges.getRowKeyRanges()
URL: https://github.com/apache/phoenix/pull/496#discussion_r279962862
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java
 ##########
 @@ -719,13 +719,23 @@ public TimeRange getRowTimestampRange() {
 
             int[] slotSpans = this.getSlotSpans();
 
-            // If the ranges here do not qualify all the keys then those keys are unbound
-            if (newRanges.size() < schema.getMaxFields()) {
+            int fieldSpan = 0;
+            for(int i = 0; i < slotSpans.length; i++){
 
 Review comment:
   add space between for and (?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services