You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ya...@apache.org on 2022/09/16 09:35:46 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #2088] Add issue template for test only fix or improvement
This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 096f77e5e [KYUUBI #2088] Add issue template for test only fix or improvement
096f77e5e is described below
commit 096f77e5e46fb333cd6d8dd1c9cfbd1f0c90526b
Author: yikf <yi...@gmail.com>
AuthorDate: Fri Sep 16 17:35:35 2022 +0800
[KYUUBI #2088] Add issue template for test only fix or improvement
### _Why are the changes needed?_
Fix https://github.com/apache/incubator-kyuubi/issues/2088
This pr aims to add a template of improve tests only.
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3496 from Yikf/test-improve-issue.
Closes #2088
7203f632 [yikf] add improve tests tmeplate
Authored-by: yikf <yi...@gmail.com>
Signed-off-by: Kent Yao <ya...@apache.org>
---
.github/ISSUE_TEMPLATE/bug-report.yml | 2 +-
.github/ISSUE_TEMPLATE/doc-improvement-report.yml | 2 +-
.github/ISSUE_TEMPLATE/feature-request.yml | 2 +-
.github/ISSUE_TEMPLATE/flaky-test-report.yml | 4 ++--
.../{improvement.yml => improve-test.yml} | 26 +++++++---------------
.github/ISSUE_TEMPLATE/improvement.yml | 2 +-
6 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml
index ef19404dc..1d70d9bf1 100644
--- a/.github/ISSUE_TEMPLATE/bug-report.yml
+++ b/.github/ISSUE_TEMPLATE/bug-report.yml
@@ -17,7 +17,7 @@
# See https://gh-community.github.io/issue-template-feedback/structured/
-name: Kyuubi Bug Report
+name: Bug Report
title: "[Bug] "
description: Describe the bug you encountered with Apache Kyuubi
labels: [ "kind:bug,priority:major" ]
diff --git a/.github/ISSUE_TEMPLATE/doc-improvement-report.yml b/.github/ISSUE_TEMPLATE/doc-improvement-report.yml
index b9db45ad0..3b731c090 100644
--- a/.github/ISSUE_TEMPLATE/doc-improvement-report.yml
+++ b/.github/ISSUE_TEMPLATE/doc-improvement-report.yml
@@ -15,7 +15,7 @@
# limitations under the License.
#
-name: Kyuubi Doc Improvement Report
+name: Doc Improvement Report
title: "[DOCS] "
description: Fix errors, or improve the content or refactor architecture of online documentation
labels: ["kind:documentation"]
diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml
index 029979327..322550489 100644
--- a/.github/ISSUE_TEMPLATE/feature-request.yml
+++ b/.github/ISSUE_TEMPLATE/feature-request.yml
@@ -15,7 +15,7 @@
# limitations under the License.
#
-name: Kyuubi Feature Request
+name: Feature Request
title: "[FEATURE] "
description: Suggest an idea for Apache Kyuubi
labels: [ "kind:feature,priority:major" ]
diff --git a/.github/ISSUE_TEMPLATE/flaky-test-report.yml b/.github/ISSUE_TEMPLATE/flaky-test-report.yml
index 7d07490f7..699c49d79 100644
--- a/.github/ISSUE_TEMPLATE/flaky-test-report.yml
+++ b/.github/ISSUE_TEMPLATE/flaky-test-report.yml
@@ -15,8 +15,8 @@
# limitations under the License.
#
-name: Kyuubi Flaky Test Report
-title: "Flaky Test: "
+name: Flaky Test Report
+title: "[TEST]: "
description: Describe the flaky test you encountered with Apache Kyuubi
labels: ["kind:bug,kind:test,priority:major"]
body:
diff --git a/.github/ISSUE_TEMPLATE/improvement.yml b/.github/ISSUE_TEMPLATE/improve-test.yml
similarity index 73%
copy from .github/ISSUE_TEMPLATE/improvement.yml
copy to .github/ISSUE_TEMPLATE/improve-test.yml
index 8cae30d18..d0440ebe3 100644
--- a/.github/ISSUE_TEMPLATE/improvement.yml
+++ b/.github/ISSUE_TEMPLATE/improve-test.yml
@@ -15,17 +15,15 @@
# limitations under the License.
#
-# See https://gh-community.github.io/issue-template-feedback/structured/
-
-name: Kyuubi Improvement
-title: "[Improvement] "
-description: Suggest an improvement on performance, code quality, user experience, etc
-labels: [ "improvement" ]
+name: Test Only Fix
+title: "[TEST]: "
+description: Describe the tests you want to improve with Apache Kyuubi
+labels: ["kind:test,priority:minor"]
body:
- type: markdown
attributes:
value: |
- Thank you for contributing to Apache Kyuubi! Your opinions are deeply valued by the community.
+ Thank you for finding the time to report the issue! We really appreciate the community's efforts to improve Kyuubi.
- type: checkboxes
attributes:
@@ -47,20 +45,12 @@ body:
- type: textarea
attributes:
- label: What would you like to be improved?
+ label: Describe the issues of the existing tests or improvements for new tests
placeholder: >
- Please describe the problem you see and how it is needed to be improved.
+ Please describe the tests problem you see and how it is needed to be improved.
validations:
required: true
- - type: textarea
- attributes:
- label: How should we improve?
- placeholder: >
- Please provide the solution if you have thoughts.
- validations:
- required: false
-
- type: checkboxes
attributes:
label: Are you willing to submit PR?
@@ -73,4 +63,4 @@ body:
- type: markdown
attributes:
- value: "Thanks for taking the time to create this improvement issue!"
+ value: "Thanks for taking the time to improve the test coverage and fix test issues."
diff --git a/.github/ISSUE_TEMPLATE/improvement.yml b/.github/ISSUE_TEMPLATE/improvement.yml
index 8cae30d18..09f7f5040 100644
--- a/.github/ISSUE_TEMPLATE/improvement.yml
+++ b/.github/ISSUE_TEMPLATE/improvement.yml
@@ -17,7 +17,7 @@
# See https://gh-community.github.io/issue-template-feedback/structured/
-name: Kyuubi Improvement
+name: Improvement
title: "[Improvement] "
description: Suggest an improvement on performance, code quality, user experience, etc
labels: [ "improvement" ]