You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/05/09 23:55:31 UTC
Re: Review Request 55895: Extract a BasicBlocks class for disk block
arithmetic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55895/#review174391
-----------------------------------------------------------
Fix it, then Ship it!
I can fix up the following the suggestions.
src/slave/containerizer/mesos/isolators/xfs/utils.cpp
Line 62 (original), 62 (patched)
<https://reviews.apache.org/r/55895/#comment247526>
This is unnecessary?
src/tests/containerizer/xfs_quota_tests.cpp
Lines 950-951 (patched)
<https://reviews.apache.org/r/55895/#comment247527>
We can group the two statements and remove the redundant "// A partial block should round up."?
- Jiang Yan Xu
On April 29, 2017, 10:41 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55895/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 10:41 a.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extract a BasicBlocks class to handle disk blocks to clarify block-based
> arithmetic in the XFS disk isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/xfs/utils.hpp eddd4c37fb42339ca21ecb392dea47acf6b277bb
> src/slave/containerizer/mesos/isolators/xfs/utils.cpp 8018ad348d26bd962357543a5fb9f6cb43ff13b1
> src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043
>
>
> Diff: https://reviews.apache.org/r/55895/diff/5/
>
>
> Testing
> -------
>
> sudo make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 55895: Extract a BasicBlocks class for disk block
arithmetic.
Posted by James Peach <jp...@apache.org>.
> On May 9, 2017, 11:55 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/xfs/utils.cpp
> > Line 62 (original), 62 (patched)
> > <https://reviews.apache.org/r/55895/diff/5/?file=1703825#file1703825line62>
> >
> > This is unnecessary?
This comment is now on the `class BasicBlocks`.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55895/#review174391
-----------------------------------------------------------
On April 29, 2017, 5:41 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55895/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 5:41 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-5116
> https://issues.apache.org/jira/browse/MESOS-5116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extract a BasicBlocks class to handle disk blocks to clarify block-based
> arithmetic in the XFS disk isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/xfs/utils.hpp eddd4c37fb42339ca21ecb392dea47acf6b277bb
> src/slave/containerizer/mesos/isolators/xfs/utils.cpp 8018ad348d26bd962357543a5fb9f6cb43ff13b1
> src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043
>
>
> Diff: https://reviews.apache.org/r/55895/diff/5/
>
>
> Testing
> -------
>
> sudo make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>