You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2016/04/29 05:06:12 UTC
[jira] [Resolved] (BOOKKEEPER-925) Fix FindBugs discovered issues
in master
[ https://issues.apache.org/jira/browse/BOOKKEEPER-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo resolved BOOKKEEPER-925.
----------------------------------
Resolution: Fixed
Issue resolved by merging pull request 40
[https://github.com/apache/bookkeeper/pull/40]
{noformat}
commit f8e0331f14a933ad2ed3d933c5eea927020b4967
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Thu Apr 28 20:05:37 2016 -0700
Commit: Sijie Guo <si...@apache.org>
CommitDate: Thu Apr 28 20:05:37 2016 -0700
BOOKKEEPER-925: Fix FindBugs discovered issues in master
sijie Fixed the other findbugs error
Author: Matteo Merli <mm...@apache.org>
Reviewers: Guo Sijie <si...@apache.org>
Closes #40 from merlimat/bk-925
{noformat}
> Fix FindBugs discovered issues in master
> ----------------------------------------
>
> Key: BOOKKEEPER-925
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-925
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Fix For: 4.4.0
>
>
> After we have fixed unit tests in master, we are seeing FindBugs warnings:
> {noformat}
> [INFO] --- findbugs-maven-plugin:2.5.2:check (default-cli) @ bookkeeper-server ---
> [INFO] BugInstance size is 6
> [INFO] Error size is 0
> [INFO] Total bugs: 6
> [INFO] Found reliance on default encoding in org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd.runCmd(CommandLine): new String(byte[]) ["org.apache.bookkeeper.bookie.BookieShell$ReadLedgerEntriesCmd"] At BookieShell.java:[lines 403-474]
> [INFO] Exception is caught when Exception is not thrown in org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector.gc(GarbageCollector$GarbageCleaner) ["org.apache.bookkeeper.bookie.ScanAndCompareGarbageCollector"] At ScanAndCompareGarbageCollector.java:[lines 64-227]
> [INFO] org.apache.bookkeeper.client.BookieWatcher.<static initializer>() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead ["org.apache.bookkeeper.client.BookieWatcher"] At BookieWatcher.java:[lines 60-308]
> [INFO] org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.LOCK_DATA should be package protected ["org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager"] At ZkLedgerUnderreplicationManager.java:[lines 76-664]
> [INFO] Synchronization performed on java.util.concurrent.ConcurrentLinkedQueue in org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler.writeRequested(ChannelHandlerContext, MessageEvent) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler"] At AuthHandler.java:[lines 210-302]
> [INFO] Synchronization performed on java.util.concurrent.ConcurrentLinkedQueue in org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback.operationComplete(int, Void) ["org.apache.bookkeeper.proto.AuthHandler$ClientSideHandler$AuthHandshakeCompleteCallback"] At AuthHandler.java:[lines 333-354]
> [INFO] ------------------------------------------------------------------------
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)