You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/01/22 00:26:58 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39690: [SPARK-42150][K8S][DOCS] Upgrade `Volcano` to 1.7.0
dongjoon-hyun commented on code in PR #39690:
URL: https://github.com/apache/spark/pull/39690#discussion_r1083372057
##########
resource-managers/kubernetes/integration-tests/README.md:
##########
@@ -364,13 +360,5 @@ You can also specify `volcano` tag to only run Volcano test:
## Cleanup Volcano
- # x86_64
- kubectl delete -f https://raw.githubusercontent.com/volcano-sh/volcano/v1.5.1/installer/volcano-development.yaml
-
- # arm64:
- kubectl delete -f https://raw.githubusercontent.com/volcano-sh/volcano/v1.5.1/installer/volcano-development-arm64.yaml
-
- # Cleanup Volcano webhook
Review Comment:
It's included by the original `YAML` now. So, if we try to clean up here again, it shows error messages because there is no such resource here.
##########
resource-managers/kubernetes/integration-tests/README.md:
##########
@@ -364,13 +360,5 @@ You can also specify `volcano` tag to only run Volcano test:
## Cleanup Volcano
- # x86_64
- kubectl delete -f https://raw.githubusercontent.com/volcano-sh/volcano/v1.5.1/installer/volcano-development.yaml
-
- # arm64:
- kubectl delete -f https://raw.githubusercontent.com/volcano-sh/volcano/v1.5.1/installer/volcano-development-arm64.yaml
-
- # Cleanup Volcano webhook
Review Comment:
Yes, It's included by the original `YAML` now. So, if we try to clean up here again, it shows error messages because there is no such resource here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org