You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/08 20:31:04 UTC

[GitHub] [geode] DonalEvans commented on pull request #7143: GEODE-9808: Throw appropriate exception in AutoConnectionSourceImpl

DonalEvans commented on pull request #7143:
URL: https://github.com/apache/geode/pull/7143#issuecomment-989172355


   > Approved. Just for my edification, will there be a similar issue in run2 in UpdateLocatorListTask, where it calls updateLocatorList with the response but we never check the hasResults field and it simply starts accessing the members and calling methods on it.
   
   I don't believe so. If we get a response with no results, then the consequence will be that we'll just mark all our old known locators as bad and not add any new ones (because the response doesn't contain any). This behaviour is unaffected by the changes in this PR, and hasn't caused problems up till now, so I have to assume that it's okay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org