You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Adaverse (via GitHub)" <gi...@apache.org> on 2023/07/01 10:55:15 UTC

[GitHub] [airflow] Adaverse opened a new pull request, #32299: Adds Sensor section in the Azure providers docs

Adaverse opened a new pull request, #32299:
URL: https://github.com/apache/airflow/pull/32299

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Adaverse commented on a diff in pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on code in PR #32299:
URL: https://github.com/apache/airflow/pull/32299#discussion_r1249391459


##########
airflow/providers/microsoft/azure/example_dag/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   It's not related to any issue or epic. There is a general agreement that if there is something (issue or feature) that you have decided to work on, then no need to open an issue for it. Just directly open the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] pragnareddye commented on a diff in pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "pragnareddye (via GitHub)" <gi...@apache.org>.
pragnareddye commented on code in PR #32299:
URL: https://github.com/apache/airflow/pull/32299#discussion_r1249372654


##########
airflow/providers/microsoft/azure/example_dag/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Is there a related issue? or open epic? Just to get some context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32299:
URL: https://github.com/apache/airflow/pull/32299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Adaverse commented on pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on PR #32299:
URL: https://github.com/apache/airflow/pull/32299#issuecomment-1617587937

   cc - @potiuk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Adaverse commented on a diff in pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on code in PR #32299:
URL: https://github.com/apache/airflow/pull/32299#discussion_r1249391459


##########
airflow/providers/microsoft/azure/example_dag/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   It's related to an issue or epic. There is a general agreement that if there is something (issue or feature) that you have decided to work on, then no need to open an issue for it. Just directly open the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Adaverse commented on a diff in pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on code in PR #32299:
URL: https://github.com/apache/airflow/pull/32299#discussion_r1249391459


##########
airflow/providers/microsoft/azure/example_dag/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   It's not related to any issue or epic. There is a general agreement that if there is something (bug or feature) that you have decided to work on, then no need to open an issue for it. Just directly open the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] pragnareddye commented on a diff in pull request #32299: Adds Sensor section in the Azure providers docs

Posted by "pragnareddye (via GitHub)" <gi...@apache.org>.
pragnareddye commented on code in PR #32299:
URL: https://github.com/apache/airflow/pull/32299#discussion_r1249679697


##########
airflow/providers/microsoft/azure/example_dag/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org