You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Maxim Fortun <ma...@maxf.net> on 2024/10/11 01:10:46 UTC
[DISCUSS] KIP-1096: Add ability to pass headers to ProducerPerformance.
Hi all,
I would like to introduce a minor enhancement to ProducerPerformance class to pass headers to the create produce requests.
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1096
Headers are useful for tracking many aspects of the performance testing. Like regions, hosts, etc...
Headers passed downstream to consumers can also drive perf test behavior.
I have submitted a PR(https://github.com/apache/kafka/pull/17462) for to add --headers arg, only to find a bit later that there is a similar PR(https://github.com/apache/kafka/pull/9254) from 2020 that adds --headers-file arg.
Looks like there was no traction on that since 2020.
I did not create a new JIRA issue, I added a comment with the second PR to an existing issue(https://issues.apache.org/jira/browse/KAFKA-10462) from 2020.
We can add either one, or both features.
Please take a look.
Any and all feedback is greatly appreciated.
Thanks,
Max
Re: [DISCUSS] KIP-1096: Add ability to pass headers to ProducerPerformance.
Posted by Andrew Schofield <an...@outlook.com>.
Hi Max,
Thanks for the KIP.
I think this is a useful addition to the ProducerPerformance tool. I think the KIP needs some more detail.
If you're adding `--headers`, you should specify how to give multiple headers. For example, is it
`--headers K1=V1,K2=V2` or do you have to do `--headers K1=V1 --headers K2=V2`?
If you use `--headers-file`, what is the format of the file?
And I'd like to suggest that you also extend the tool with a `--bootstrap-server` option. It's annoying when
using `kafka-producer-perf-test.sh` and `kafka-consumer-perf-test.sh` together that they are inconsistent in
how you provide the bootstrap server address. Feel free to ignore this suggestion, but since you're in there....
Thanks,
Andrew
________________________________________
From: Maxim Fortun <ma...@maxf.net>
Sent: 11 October 2024 02:10
To: dev@kafka.apache.org <de...@kafka.apache.org>
Subject: [DISCUSS] KIP-1096: Add ability to pass headers to ProducerPerformance.
Hi all,
I would like to introduce a minor enhancement to ProducerPerformance class to pass headers to the create produce requests.
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1096
Headers are useful for tracking many aspects of the performance testing. Like regions, hosts, etc...
Headers passed downstream to consumers can also drive perf test behavior.
I have submitted a PR(https://github.com/apache/kafka/pull/17462) for to add --headers arg, only to find a bit later that there is a similar PR(https://github.com/apache/kafka/pull/9254) from 2020 that adds --headers-file arg.
Looks like there was no traction on that since 2020.
I did not create a new JIRA issue, I added a comment with the second PR to an existing issue(https://issues.apache.org/jira/browse/KAFKA-10462) from 2020.
We can add either one, or both features.
Please take a look.
Any and all feedback is greatly appreciated.
Thanks,
Max