You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by sm...@apache.org on 2015/01/27 13:54:29 UTC
[02/23] directory-fortress-core git commit: FC-25 - Improve the way
Factories create instances
FC-25 - Improve the way Factories create instances
Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/dcfed51c
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/dcfed51c
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/dcfed51c
Branch: refs/heads/master
Commit: dcfed51c5641ac9d8b2143549d53008d63a381fc
Parents: 3966a15
Author: Shawn McKinney <sm...@apache.org>
Authored: Sat Dec 20 11:23:37 2014 -0600
Committer: Shawn McKinney <sm...@apache.org>
Committed: Sat Dec 20 11:23:37 2014 -0600
----------------------------------------------------------------------
.../fortress/core/samples/package.html | 50 ++++++++++++++++++++
.../fortress/core/AccelMgrFactory.java | 8 +++-
.../fortress/core/AccessMgrFactory.java | 11 +++--
.../fortress/core/AdminMgrFactory.java | 11 +++--
.../fortress/core/AuditMgrFactory.java | 11 +++--
.../fortress/core/DelAccessMgrFactory.java | 11 +++--
.../fortress/core/DelAdminMgrFactory.java | 12 +++--
.../fortress/core/DelReviewMgrFactory.java | 11 +++--
.../fortress/core/PwPolicyMgrFactory.java | 11 +++--
.../fortress/core/ReviewMgrFactory.java | 11 +++--
.../fortress/core/rbac/AccessMgrImpl.java | 7 ---
.../fortress/core/rbac/AdminMgrImpl.java | 6 ---
.../fortress/core/rbac/AuditMgrImpl.java | 4 --
.../fortress/core/rbac/DelAccessMgrImpl.java | 4 --
.../fortress/core/rbac/DelAdminMgrImpl.java | 4 --
.../fortress/core/rbac/DelReviewMgrImpl.java | 4 --
.../fortress/core/rbac/PwPolicyMgrImpl.java | 4 --
.../fortress/core/rbac/ReviewMgrImpl.java | 4 --
18 files changed, 120 insertions(+), 64 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/out/test/directory-fortress-core/org/apache/directory/fortress/core/samples/package.html
----------------------------------------------------------------------
diff --git a/out/test/directory-fortress-core/org/apache/directory/fortress/core/samples/package.html b/out/test/directory-fortress-core/org/apache/directory/fortress/core/samples/package.html
new file mode 100755
index 0000000..9881d96
--- /dev/null
+++ b/out/test/directory-fortress-core/org/apache/directory/fortress/core/samples/package.html
@@ -0,0 +1,50 @@
+<!--
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+-->
+<html>
+ <head>
+ <title>Package Documentation for org.openldap.fortress.samples</title>
+ </head>
+ <body>
+ <p>
+ This package contains samples that show how the Fortress APIs can be used. The samples use JUnit
+ and provide the following.
+ <h3>Samples</h3>
+ <ol>
+ <li>{@link org.openldap.fortress.samples.AccessMgrSample} demonstrates {@code org.openldap.fortress.AccessMgr} APIs</li>
+ <li>{@link org.openldap.fortress.samples.AllSamplesJUnitTest} will execute all tests in their proper order</li>
+ <li>{@link org.openldap.fortress.samples.CreatePermOrgHierarchySample} demonstrates {@code org.openldap.fortress.DelegatedAdminMgr} APis to create Perm organizational unit hierarchies</li>
+ <li>{@link org.openldap.fortress.samples.CreatePermOrgSample} demonstrates {@code org.openldap.fortress.DelegatedAdminMgr} APis to create a Perm organizational unit node</li>
+ <li>{@link org.openldap.fortress.samples.CreatePermSample} demonstrates {@code org.openldap.fortress.AdminMgr} to create RBAC permissions</li>
+ <li>{@link org.openldap.fortress.samples.CreateRoleHierarchySample} demonstrates {@code org.openldap.fortress.AdminMgr} to create RBAC Role hierarchies</li>
+ <li>{@link org.openldap.fortress.samples.CreateRoleSample} demonstrates {@code org.openldap.fortress.AdminMgr} to create RBAC Roles and assign constraints</li>
+ <li>{@link org.openldap.fortress.samples.CreateSessionSample} demonstrates various ways to create a session using {@code org.openldap.fortress.AccessMgr} APIs</li>
+ <li>{@link org.openldap.fortress.samples.CreateUserOrgHierarchySample} demonstrates {@code org.openldap.fortress.DelegatedAdminMgr} APis to create User organizational unit hierarchies</li>
+ <li>{@link org.openldap.fortress.samples.CreateUserOrgSample} demonstrates {@code org.openldap.fortress.DelegatedAdminMgr} APis to create a User organizational unit node</li>
+ <li>{@link org.openldap.fortress.samples.CreateUserRoleSample} demonstrates {@code org.openldap.fortress.AdminMgr} APIs to assign Roles to Users</li>
+ <li>{@link org.openldap.fortress.samples.CreateUserSample} demonstrates {@code org.openldap.fortress.AdminMgr} APIs to create User object nodes</li>
+ </ol>
+ </p>
+ <p>
+ The <b>org.openldap.fortress.samples</b> package provides examples on proper usage of Fortress APIs, Each sample contains javadoc and JUnit test case that describes
+ the use case and function for a particular entity.
+ For more info, check out the javadoc pertaining to each sample.
+ </p>
+ </body>
+</html>
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
index 032cc8a..a1a68e6 100644
--- a/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
@@ -62,12 +62,16 @@ public class AccelMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ AccelMgr accelMgr;
if (!VUtil.isNotNullOrEmpty(accelClassName))
{
- accelClassName = AccelMgrImpl.class.getName();
+ accelMgr = new AccelMgrImpl();
+ }
+ else
+ {
+ accelMgr = (AccelMgr) ClassUtil.createInstance(accelClassName);
}
- AccelMgr accelMgr = (AccelMgr) ClassUtil.createInstance(accelClassName);
accelMgr.setContextId(contextId);
return accelMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
index 076e37e..c040173 100755
--- a/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
@@ -62,19 +62,24 @@ public class AccessMgrFactory
public static AccessMgr createInstance( String contextId) throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+
+ AccessMgr accessMgr;
if (!VUtil.isNotNullOrEmpty(accessClassName))
{
if(GlobalIds.IS_REST)
{
- accessClassName = AccessMgrRestImpl.class.getName();
+ accessMgr = new AccessMgrRestImpl();
}
else
{
- accessClassName = AccessMgrImpl.class.getName();
+ accessMgr = new AccessMgrImpl();
}
}
+ else
+ {
+ accessMgr = (AccessMgr) ClassUtil.createInstance(accessClassName);
+ }
- AccessMgr accessMgr = (AccessMgr) ClassUtil.createInstance(accessClassName);
accessMgr.setContextId(contextId);
return accessMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
index e6cd9dc..9349c30 100755
--- a/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
@@ -65,19 +65,24 @@ public class AdminMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ AdminMgr adminMgr;
+
if (!VUtil.isNotNullOrEmpty(adminClassName))
{
if(GlobalIds.IS_REST)
{
- adminClassName = AdminMgrRestImpl.class.getName();
+ adminMgr = new AdminMgrRestImpl();
}
else
{
- adminClassName = AdminMgrImpl.class.getName();
+ adminMgr = new AdminMgrImpl();
}
}
+ else
+ {
+ adminMgr = (AdminMgr) ClassUtil.createInstance(adminClassName);
+ }
- AdminMgr adminMgr = (AdminMgr) ClassUtil.createInstance(adminClassName);
adminMgr.setContextId(contextId);
return adminMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
index 8a28dd0..8eabc83 100755
--- a/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
@@ -63,19 +63,24 @@ public class AuditMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ AuditMgr auditMgr;
+
if (!VUtil.isNotNullOrEmpty(auditClassName))
{
if(GlobalIds.IS_REST)
{
- auditClassName = AuditMgrRestImpl.class.getName();
+ auditMgr = new AuditMgrRestImpl();
}
else
{
- auditClassName = AuditMgrImpl.class.getName();
+ auditMgr = new AuditMgrImpl();
}
}
+ else
+ {
+ auditMgr = (AuditMgr) ClassUtil.createInstance(auditClassName);
+ }
- AuditMgr auditMgr = (AuditMgr) ClassUtil.createInstance(auditClassName);
auditMgr.setContextId(contextId);
return auditMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
index e355a67..7902b1f 100755
--- a/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
@@ -64,19 +64,24 @@ public class DelAccessMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ DelAccessMgr accessMgr;
+
if (!VUtil.isNotNullOrEmpty(accessClassName))
{
if(GlobalIds.IS_REST)
{
- accessClassName = DelAccessMgrRestImpl.class.getName();
+ accessMgr = new DelAccessMgrRestImpl();
}
else
{
- accessClassName = DelAccessMgrImpl.class.getName();
+ accessMgr = new DelAccessMgrImpl();
}
}
+ else
+ {
+ accessMgr = (DelAccessMgr) ClassUtil.createInstance(accessClassName);
+ }
- DelAccessMgr accessMgr = (DelAccessMgr) ClassUtil.createInstance(accessClassName);
accessMgr.setContextId(contextId);
return accessMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/DelAdminMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/DelAdminMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/DelAdminMgrFactory.java
index 1db31d6..0f2b295 100755
--- a/src/main/java/org/apache/directory/fortress/core/DelAdminMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/DelAdminMgrFactory.java
@@ -65,20 +65,24 @@ public class DelAdminMgrFactory
throws SecurityException
{
VUtil.assertNotNull( contextId, GlobalErrIds.CONTEXT_NULL, CREATE_INSTANCE_METHOD );
-
+ DelAdminMgr delAdminMgr;
+
if ( Strings.isEmpty( dAdminClassName ) )
{
if ( GlobalIds.IS_REST )
{
- dAdminClassName = DelAdminMgrRestImpl.class.getName();
+ delAdminMgr = new DelAdminMgrRestImpl();
}
else
{
- dAdminClassName = DelAdminMgrImpl.class.getName();
+ delAdminMgr = new DelAdminMgrImpl();
}
}
+ else
+ {
+ delAdminMgr = (DelAdminMgr) ClassUtil.createInstance( dAdminClassName );
+ }
- DelAdminMgr delAdminMgr = (DelAdminMgr) ClassUtil.createInstance( dAdminClassName );
delAdminMgr.setContextId(contextId);
return delAdminMgr;
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
index b751a90..e89ca89 100755
--- a/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
@@ -63,19 +63,24 @@ public class DelReviewMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ DelReviewMgr delReviewMgr;
+
if (!VUtil.isNotNullOrEmpty(dReviewClassName))
{
if(GlobalIds.IS_REST)
{
- dReviewClassName = DelReviewMgrRestImpl.class.getName();
+ delReviewMgr = new DelReviewMgrRestImpl();
}
else
{
- dReviewClassName = DelReviewMgrImpl.class.getName();
+ delReviewMgr = new DelReviewMgrImpl();
}
}
+ else
+ {
+ delReviewMgr = (DelReviewMgr) ClassUtil.createInstance(dReviewClassName);
+ }
- DelReviewMgr delReviewMgr = (DelReviewMgr) ClassUtil.createInstance(dReviewClassName);
delReviewMgr.setContextId(contextId);
return delReviewMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
index d432df1..fef7355 100755
--- a/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
@@ -63,19 +63,24 @@ public class PwPolicyMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ PwPolicyMgr policyMgr;
+
if (!VUtil.isNotNullOrEmpty(policyClassName))
{
if(GlobalIds.IS_REST)
{
- policyClassName = PwPolicyMgrRestImpl.class.getName();
+ policyMgr = new PwPolicyMgrRestImpl();
}
else
{
- policyClassName = PwPolicyMgrImpl.class.getName();
+ policyMgr = new PwPolicyMgrImpl();
}
}
+ else
+ {
+ policyMgr = (PwPolicyMgr) ClassUtil.createInstance(policyClassName);
+ }
- PwPolicyMgr policyMgr = (PwPolicyMgr) ClassUtil.createInstance(policyClassName);
policyMgr.setContextId(contextId);
return policyMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
index 95baef6..0e477ee 100755
--- a/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
@@ -63,19 +63,24 @@ public class ReviewMgrFactory
throws SecurityException
{
VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
+ ReviewMgr reviewMgr;
+
if (!VUtil.isNotNullOrEmpty(reviewClassName))
{
if(GlobalIds.IS_REST)
{
- reviewClassName = ReviewMgrRestImpl.class.getName();
+ reviewMgr = new ReviewMgrRestImpl();
}
else
{
- reviewClassName = ReviewMgrImpl.class.getName();
+ reviewMgr = new ReviewMgrImpl();
}
}
+ else
+ {
+ reviewMgr = ( ReviewMgr ) ClassUtil.createInstance(reviewClassName);
+ }
- ReviewMgr reviewMgr = ( ReviewMgr ) ClassUtil.createInstance(reviewClassName);
reviewMgr.setContextId(contextId);
return reviewMgr;
}
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/AccessMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/AccessMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/AccessMgrImpl.java
index 9749736..4bb8ec3 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/AccessMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/AccessMgrImpl.java
@@ -74,13 +74,6 @@ public class AccessMgrImpl extends Manageable implements AccessMgr
private static final UserP userP = new UserP();
private static final PermP permP = new PermP();
-
- // package private constructor ensures outside classes cannot use:
- protected AccessMgrImpl()
- {
- }
-
-
/**
* Perform user authentication only. It does not activate RBAC roles in session but will evaluate
* password policies.
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/AdminMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/AdminMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/AdminMgrImpl.java
index c27318b..8c3bce5 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/AdminMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/AdminMgrImpl.java
@@ -84,12 +84,6 @@ public final class AdminMgrImpl extends Manageable implements AdminMgr
private static final Logger LOG = LoggerFactory.getLogger( CLS_NM );
- // package private constructor ensures outside classes cannot use:
- AdminMgrImpl()
- {
- }
-
-
/**
* This command creates a new RBAC user. The command is valid only if the new user is
* not already a member of the USERS data set. The USER data set is updated. The new user
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/AuditMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/AuditMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/AuditMgrImpl.java
index 8b06405..c90cd76 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/AuditMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/AuditMgrImpl.java
@@ -78,10 +78,6 @@ public class AuditMgrImpl extends Manageable implements AuditMgr
private static final String CLS_NM = AuditMgrImpl.class.getName();
private static final AuditP auditP = new AuditP();
- // package private constructor ensures outside classes cannot use:
- AuditMgrImpl()
- {}
-
/**
* This method returns a list of authorization events for a particular user {@link org.apache.directory.fortress.core.rbac.UserAudit#userId}
* and given timestamp field {@link org.apache.directory.fortress.core.rbac.UserAudit#beginDate}.<BR>
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/DelAccessMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/DelAccessMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/DelAccessMgrImpl.java
index 0c7785a..4fa054c 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/DelAccessMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/DelAccessMgrImpl.java
@@ -59,10 +59,6 @@ public class DelAccessMgrImpl extends AccessMgrImpl implements DelAccessMgr
private static final PermP permP = new PermP();
private static final String SUPER_ADMIN = Config.getProperty("superadmin.role", "fortress-core-super-admin");
- // package private constructor ensures outside classes cannot use:
- /* No qualifier */ DelAccessMgrImpl()
- {}
-
/**
* This function will determine if the user contains an AdminRole that is authorized assignment control over
* User-Role Assignment (URA). This adheres to the ARBAC02 functional specification for can-assign URA.
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
index 43c8a09..6c5a60b 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/DelAdminMgrImpl.java
@@ -56,10 +56,6 @@ public final class DelAdminMgrImpl extends Manageable implements DelAdminMgr
private static final PermP permP = new PermP();
private static final UserP userP = new UserP();
- // package private constructor ensures outside classes cannot use:
- DelAdminMgrImpl()
- {}
-
/**
* This command creates a new admin role. The command is valid if and only if the new admin role is not
* already a member of the ADMIN ROLES data set. The ADMIN ROLES data set is updated.
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/DelReviewMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/DelReviewMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/DelReviewMgrImpl.java
index c4caa02..eea4b0b 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/DelReviewMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/DelReviewMgrImpl.java
@@ -50,10 +50,6 @@ public class DelReviewMgrImpl extends Manageable implements DelReviewMgr
private static final OrgUnitP ouP = new OrgUnitP();
private static final AdminRoleP admRP = new AdminRoleP();
- // package private constructor ensures outside classes cannot use:
- DelReviewMgrImpl()
- {}
-
/**
* Method reads Admin Role entity from the admin role container in directory.
* <h4>required parameters</h4>
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/PwPolicyMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/PwPolicyMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/PwPolicyMgrImpl.java
index 1a9ca3e..3538437 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/PwPolicyMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/PwPolicyMgrImpl.java
@@ -61,10 +61,6 @@ public class PwPolicyMgrImpl extends Manageable implements PwPolicyMgr
private static final PolicyP policyP = new PolicyP();
private static final UserP userP = new UserP();
- // package private constructor ensures outside classes cannot use:
- PwPolicyMgrImpl()
- {}
-
/**
* This method will add a new policy entry to the POLICIES data set. This command is valid
* if and only if the policy entry is not already present in the POLICIES data set.
http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/dcfed51c/src/main/java/org/apache/directory/fortress/core/rbac/ReviewMgrImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rbac/ReviewMgrImpl.java b/src/main/java/org/apache/directory/fortress/core/rbac/ReviewMgrImpl.java
index 43314aa..60dfa92 100755
--- a/src/main/java/org/apache/directory/fortress/core/rbac/ReviewMgrImpl.java
+++ b/src/main/java/org/apache/directory/fortress/core/rbac/ReviewMgrImpl.java
@@ -72,10 +72,6 @@ public class ReviewMgrImpl extends Manageable implements ReviewMgr
private static final PermP permP = new PermP();
private static final SdP ssdP = new SdP();
- // package private constructor ensures outside classes cannot use:
- ReviewMgrImpl()
- {}
-
/**
* This method returns a matching permission entity to caller.
* <h4>required parameters</h4>