[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #31024: Some minor updates to the Airflow release Doc

["ephraimbuddy (via GitHub)" <gi...@apache.org>]

ephraimbuddy commented on code in PR #31024:
URL: https://github.com/apache/airflow/pull/31024#discussion_r1182964749


##########
dev/breeze/src/airflow_breeze/commands/release_command.py:
##########
@@ -49,25 +50,13 @@ def create_version_dir(version):
         console_print(f"{version} directory created")
 
 
-def copy_artifacts_to_svn(rc, svn_dev_repo):
+def copy_artifacts_to_svn(rc, svn_dev_repo, svn_version_dir):
     if confirm_action(f"Copy artifacts to SVN for {rc}?"):
-        run_command(
-            [
-                "for",
-                "f",
-                "in",
-                f"{svn_dev_repo}/{rc}/*",
-                ";",
-                "do",
-                "svn",
-                "cp",
-                "$f",
-                "${$(basename $f)/}",
-                "done",
-            ],
-            dry_run_override=DRY_RUN,
-            check=True,
-        )
+        dev_rc_path = f"{svn_dev_repo}/{rc}/"
+        if not DRY_RUN:
+            for filename in os.listdir(dev_rc_path):
+                source_file = os.path.join(dev_rc_path, filename)
+                shutil.copy(source_file, svn_version_dir)

Review Comment:
   How do we correct the command because it didn't work when I used it? The error was "no such file 'for'". Maybe peculiar to M1?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org