[GitHub] [pinot] stym06 commented on a diff in pull request #8779: Change DateTimeFormatSpec delimiter

[GitBox <gi...@apache.org>]

stym06 commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r886691428


##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java:
##########
@@ -84,6 +127,23 @@ public DateTimeFormatSpec(int columnSize, String columnUnit, String columnTimeFo
     _patternSpec = new DateTimeFormatPatternSpec(columnTimeFormat);
   }
 
+  /**
+   * Constructs a dateTimeSpec format, given the components of a format
+   */
+  public DateTimeFormatSpec(String columnTimeFormat, String columnUnit, int columnSize) {

Review Comment:
   Actually, the tests are using the constructors. Writing the tests without the constructors would not be possible.
   
   https://github.com/apache/pinot/blob/f8c728f8de4c393f4f768887351f244e0661b89d/pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java#L403
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org