You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "dennis lucero (JIRA)" <ji...@apache.org> on 2008/08/20 22:30:44 UTC

[jira] Created: (WICKET-1794) WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together

WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together
----------------------------------------------------------------------------

                 Key: WICKET-1794
                 URL: https://issues.apache.org/jira/browse/WICKET-1794
             Project: Wicket
          Issue Type: Bug
    Affects Versions: 1.4-M3
            Reporter: dennis lucero
             Fix For: 1.4-M4


IndexedParamUrlCodingStrategy.appendParameters expects String->String map:
....
		while (parameters.containsKey(String.valueOf(i)))
		{
			String value = (String)parameters.get(String.valueOf(i));
...
but BaseWicketTester.clickLink converts page params to String->String[] map:
....
					PageParameters parameters = (PageParameters)getParametersMethod.invoke(
						bookmarkablePageLink, (Object[])null);
					setParametersForNextRequest(parameters.toRequestParameters());
...
And as result we have type cast exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1794) WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1794:
---------------------------------------

    Fix Version/s:     (was: 1.4-RC1)
                   1.4-RC2

> WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-1794
>                 URL: https://issues.apache.org/jira/browse/WICKET-1794
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4-M3
>            Reporter: dennis lucero
>             Fix For: 1.4-RC2
>
>
> IndexedParamUrlCodingStrategy.appendParameters expects String->String map:
> ....
> 		while (parameters.containsKey(String.valueOf(i)))
> 		{
> 			String value = (String)parameters.get(String.valueOf(i));
> ...
> but BaseWicketTester.clickLink converts page params to String->String[] map:
> ....
> 					PageParameters parameters = (PageParameters)getParametersMethod.invoke(
> 						bookmarkablePageLink, (Object[])null);
> 					setParametersForNextRequest(parameters.toRequestParameters());
> ...
> And as result we have type cast exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1794) WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together

Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Borges updated WICKET-1794:
---------------------------------

    Attachment: patch-WICKET-1794.diff

Patch attached.

The fix is to check for a String array inside appendParameters as wouldn't be a good idea  to change WicketTester.

Bruno

> WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-1794
>                 URL: https://issues.apache.org/jira/browse/WICKET-1794
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4-M3
>            Reporter: dennis lucero
>             Fix For: 1.4-RC2
>
>         Attachments: patch-WICKET-1794.diff
>
>
> IndexedParamUrlCodingStrategy.appendParameters expects String->String map:
> ....
> 		while (parameters.containsKey(String.valueOf(i)))
> 		{
> 			String value = (String)parameters.get(String.valueOf(i));
> ...
> but BaseWicketTester.clickLink converts page params to String->String[] map:
> ....
> 					PageParameters parameters = (PageParameters)getParametersMethod.invoke(
> 						bookmarkablePageLink, (Object[])null);
> 					setParametersForNextRequest(parameters.toRequestParameters());
> ...
> And as result we have type cast exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1794) WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1794.
-----------------------------------

    Resolution: Fixed
      Assignee: Igor Vaynberg

> WicketTester.clickLink and IndexedParamUrlCodingStrategy don't work together
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-1794
>                 URL: https://issues.apache.org/jira/browse/WICKET-1794
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4-M3
>            Reporter: dennis lucero
>            Assignee: Igor Vaynberg
>             Fix For: 1.4-RC2
>
>         Attachments: patch-WICKET-1794.diff
>
>
> IndexedParamUrlCodingStrategy.appendParameters expects String->String map:
> ....
> 		while (parameters.containsKey(String.valueOf(i)))
> 		{
> 			String value = (String)parameters.get(String.valueOf(i));
> ...
> but BaseWicketTester.clickLink converts page params to String->String[] map:
> ....
> 					PageParameters parameters = (PageParameters)getParametersMethod.invoke(
> 						bookmarkablePageLink, (Object[])null);
> 					setParametersForNextRequest(parameters.toRequestParameters());
> ...
> And as result we have type cast exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.