[GitHub] [incubator-druid] AlexandreYang commented on a change in pull request #8472: [statsd-emitter] Fix service tag by avoiding using a reserved word

[GitBox <gi...@apache.org>]

AlexandreYang commented on a change in pull request #8472: [statsd-emitter] Fix service tag by avoiding using a reserved word
URL: https://github.com/apache/incubator-druid/pull/8472#discussion_r321409017
 
 

 ##########
 File path: extensions-contrib/statsd-emitter/src/test/java/org/apache/druid/emitter/statsd/StatsDEmitterTest.java
 ##########
 @@ -181,7 +181,7 @@ public void testServiceAsTagOption()
             client
     );
     client.time("druid.query.time", 10,
-            "service:druid/broker", "dataSource:data-source", "type:groupBy", "hostname:brokerHost1"
+            "druidService:druid/broker", "dataSource:data-source", "type:groupBy", "hostname:brokerHost1"
 
 Review comment:
   The list of reserved is on this documentation: https://docs.datadoghq.com/tagging/
   
   Testing that would mean adding the list of reserve words in this project, we will need to maintain that list to match the "source of truth" that is elsewhere (the doc above). So I'm not sure it worth it. What do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org