You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (Created) (JIRA)" <ji...@apache.org> on 2011/11/23 11:37:40 UTC
[jira] [Created] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Hedwig client doesn't kill and remove old subscription channel after redirection.
---------------------------------------------------------------------------------
Key: BOOKKEEPER-118
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
Project: Bookkeeper
Issue Type: Bug
Components: hedwig-client
Affects Versions: 4.0.0
Reporter: Sijie Guo
Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Posted by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155808#comment-13155808 ]
Sijie Guo commented on BOOKKEEPER-118:
--------------------------------------
in hedwig java client, we did close old subscription channels in SubscribeResponseHandler when it is not a SUCCESS response.
{code}
// Main method to handle Subscribe responses from the server that we sent
// a Subscribe Request to.
public void handleSubscribeResponse(PubSubResponse response, PubSubData pubSubData, Channel channel)
throws Exception {
// If this was not a successful response to the Subscribe request, we
// won't be using the Netty Channel created so just close it.
if (!response.getStatusCode().equals(StatusCode.SUCCESS)) {
HedwigClientImpl.getResponseHandlerFromChannel(channel).channelClosedExplicitly = true;
channel.close();
}
...
}
{code}
this issue just happens in hedwig cpp client.
> Hedwig client doesn't kill and remove old subscription channel after redirection.
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-118
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158388#comment-13158388 ]
Hudson commented on BOOKKEEPER-118:
-----------------------------------
Integrated in bookkeeper-trunk #241 (See [https://builds.apache.org/job/bookkeeper-trunk/241/])
BOOKKEEPER-118: Hedwig client doesn't kill and remove old subscription channel after redirection. (Sijie Guo via ivank)
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/clientimpl.cpp
> Hedwig client doesn't kill and remove old subscription channel after redirection.
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-118
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158363#comment-13158363 ]
Ivan Kelly commented on BOOKKEEPER-118:
---------------------------------------
This patch wasn't generated with --no-prefix. It's not a problem, but it's preferable to have patchs apply with -p0.
> Hedwig client doesn't kill and remove old subscription channel after redirection.
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-118
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158364#comment-13158364 ]
Ivan Kelly commented on BOOKKEEPER-118:
---------------------------------------
lgtm +1, will commit now.
> Hedwig client doesn't kill and remove old subscription channel after redirection.
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-118
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-118) Hedwig client doesn't kill and
remove old subscription channel after redirection.
Posted by "Sijie Guo (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-118:
---------------------------------
Attachment: BOOKKEEPER-118.possiblefix.patch
attach a patch to close old subscription channels during redirection in hedwig cpp client.
> Hedwig client doesn't kill and remove old subscription channel after redirection.
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-118
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-118
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
> Affects Versions: 4.0.0
> Reporter: Sijie Guo
> Attachments: BOOKKEEPER-118.possiblefix.patch
>
>
> Currently we found that hedwig cpp client doesn't kill and remove old subscription channels after redirection, so there is lots of unused channels.
> Not sure whether hedwig java client has the same issue, need to check it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira