You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 00:05:30 UTC

[GitHub] [arrow] ianmcook commented on a diff in pull request #12460: ARROW-13530: [C++] Implement cumulative sum compute function

ianmcook commented on code in PR #12460:
URL: https://github.com/apache/arrow/pull/12460#discussion_r845643144


##########
docs/source/python/api/compute.rst:
##########
@@ -45,6 +45,21 @@ Aggregations
    tdigest
    variance
 
+Cumulative Functions
+--------------------
+
+Cumulative functions are vector functions that perform a running total on its
+input and outputs an array containing the corresponding intermediate running values.

Review Comment:
   I am worried that users are going to misunderstand what this function does. Is there some way we can clarify that it does _not_ iterate down a column accumulating the values in the rows of the column? I think my earlier comment about this was misunderstood.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org