You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/09/30 18:12:22 UTC
Review Request 26053: UI: Upgrade jquery-validate lib to the latest
1.13.0 version with the additional-methods included.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26053/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Bugs: CLOUDSTACK-7659
https://issues.apache.org/jira/browse/CLOUDSTACK-7659
Repository: cloudstack-git
Description
-------
This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well.
Diffs
-----
LICENSE 497323bffce2b2afab28c187cfdafa960944ed94
ui/index.jsp e0b4b7848175e3f2159d44d6ac48d122858a2854
ui/lib/jquery.validate.additional-methods.js PRE-CREATION
ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84
Diff: https://reviews.apache.org/r/26053/diff/
Testing
-------
Tested that the validation is still working as expected.
Thanks,
Gabor Apati-Nagy
Re: Review Request 26053: UI: Upgrade jquery-validate lib to the
latest 1.13.0 version with the additional-methods included.
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
> On Oct. 8, 2014, 11:46 a.m., Rohit Yadav wrote:
> > Looks like an additional jquery-validate library was added, can you explain what this does such as validates what in the frontend?
It adds extra validation capabilities to the jquery-validation plugin that we are already using. At the moment none of them is used, but once this has been committed I will quickly add validations for ipv4, ipv6, url fields for example.
It will be that easy:
ip_address_field: {
required: true,
ipv4: true //this will use the ipv4 validator defined in the additional-methods lib
}
- Gabor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26053/#review55783
-----------------------------------------------------------
On Sept. 30, 2014, 5:12 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26053/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 5:12 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7659
> https://issues.apache.org/jira/browse/CLOUDSTACK-7659
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well.
>
>
> Diffs
> -----
>
> LICENSE 497323bffce2b2afab28c187cfdafa960944ed94
> ui/index.jsp e0b4b7848175e3f2159d44d6ac48d122858a2854
> ui/lib/jquery.validate.additional-methods.js PRE-CREATION
> ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84
>
> Diff: https://reviews.apache.org/r/26053/diff/
>
>
> Testing
> -------
>
> Tested that the validation is still working as expected.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 26053: UI: Upgrade jquery-validate lib to the
latest 1.13.0 version with the additional-methods included.
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26053/#review55783
-----------------------------------------------------------
Looks like an additional jquery-validate library was added, can you explain what this does such as validates what in the frontend?
- Rohit Yadav
On Sept. 30, 2014, 4:12 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26053/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2014, 4:12 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7659
> https://issues.apache.org/jira/browse/CLOUDSTACK-7659
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well.
>
>
> Diffs
> -----
>
> LICENSE 497323bffce2b2afab28c187cfdafa960944ed94
> ui/index.jsp e0b4b7848175e3f2159d44d6ac48d122858a2854
> ui/lib/jquery.validate.additional-methods.js PRE-CREATION
> ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84
>
> Diff: https://reviews.apache.org/r/26053/diff/
>
>
> Testing
> -------
>
> Tested that the validation is still working as expected.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 26053: UI: Upgrade jquery-validate lib to the
latest 1.13.0 version with the additional-methods included.
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26053/#review58680
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Oct. 27, 2014, 5:10 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26053/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:10 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7659
> https://issues.apache.org/jira/browse/CLOUDSTACK-7659
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well.
>
>
> Diffs
> -----
>
> LICENSE 497323bffce2b2afab28c187cfdafa960944ed94
> ui/index.jsp 42973f70855d0ef00391cf69ddd895d0b832aa8a
> ui/lib/jquery.validate.additional-methods.js PRE-CREATION
> ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84
> ui/scripts/ui/core.js add7d06dedb1101b152fee53caa300d0104ab2cc
>
> Diff: https://reviews.apache.org/r/26053/diff/
>
>
> Testing
> -------
>
> Tested that the validation is still working as expected.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
Re: Review Request 26053: UI: Upgrade jquery-validate lib to the
latest 1.13.0 version with the additional-methods included.
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26053/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 5:10 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Changes
-------
Fixed core.js where obsolete function was called, changed jQuery.format to jQuery.validator.format.
Bugs: CLOUDSTACK-7659
https://issues.apache.org/jira/browse/CLOUDSTACK-7659
Repository: cloudstack-git
Description
-------
This patch upgrades jquery-validation library and also adds the additional-methods.js extension that offers additional validation options (same license applies, same publisher). I also updated the LICENSE file to show the added file as well.
Diffs (updated)
-----
LICENSE 497323bffce2b2afab28c187cfdafa960944ed94
ui/index.jsp 42973f70855d0ef00391cf69ddd895d0b832aa8a
ui/lib/jquery.validate.additional-methods.js PRE-CREATION
ui/lib/jquery.validate.js 72296a61f208298f2e54ac7b54b70557f41e0f84
ui/scripts/ui/core.js add7d06dedb1101b152fee53caa300d0104ab2cc
Diff: https://reviews.apache.org/r/26053/diff/
Testing
-------
Tested that the validation is still working as expected.
Thanks,
Gabor Apati-Nagy