You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Praveen Kumar Desabandu (JIRA)" <ji...@apache.org> on 2018/11/26 11:41:00 UTC
[jira] [Comment Edited] (ARROW-3860) [Gandiva] [C++] Fix packaging
broken recently
[ https://issues.apache.org/jira/browse/ARROW-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698820#comment-16698820 ]
Praveen Kumar Desabandu edited comment on ARROW-3860 at 11/26/18 11:40 AM:
---------------------------------------------------------------------------
Wes,
I figured a way to customize crossbow to use the flags only in dremio build context.
But tons of tests are failing with that flag on. Here is a build [link.|https://travis-ci.org/praveenbingo/arrow-build/builds/459690214]
The tests fail even after hiding symbols so i am guessing it is a double free or something similar due to duplicate linking (the tests link dynamically to stdc++)
Would it be an easier fix to only link the jni libraries statically to stdc++? They would anyway be used in the Java context and would need it work in different environments. This would prevent the core gandiva libraries having these static links.
was (Author: praveenbingo):
Wes,
I figured a way to customize crossbow to use the flags only in dremio build context.
But tons of tests are failing with that flag on. Here is a build [link.|https://travis-ci.org/praveenbingo/arrow-build/builds/459690214]
Would it be an easier fix to only link the jni libraries statically to stdc++? They would anyway be used in the Java context and would need it work in different environments. This would prevent the core gandiva libraries having these static links.
> [Gandiva] [C++] Fix packaging broken recently
> ---------------------------------------------
>
> Key: ARROW-3860
> URL: https://issues.apache.org/jira/browse/ARROW-3860
> Project: Apache Arrow
> Issue Type: Task
> Reporter: Praveen Kumar Desabandu
> Assignee: Praveen Kumar Desabandu
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This [commit|https://github.com/apache/arrow/commit/ba2b2ea2301f067cc95306e11546ddb6d402a55c#diff-d5e5df5984ba660e999a7c657039f6af] broke gandiva packaging by removing static linking of std c++, since dremio consumes a fat jar that includes packaged gandiva native libraries we would need to statically link std c++
> As suggested in the commit message will re-introduce it as a CMake Flag.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)