You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/04/27 01:24:06 UTC
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21362
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
This patch addresses heap-use-after-free and data race issues reported
in KUDU-3570. With this and one prior patch, neither TSAN nor ASAN
reports any warnings when running alter_table-randomized-test, at least
that's the stats collected from more than 100 iterations.
Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
---
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
2 files changed, 15 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/21362/1
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21362 )
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2024 06:16:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21362 )
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
Patch Set 1: Verified+1
unrelated test failulres:
* AuthzProviders/MasterAuthzITest.TestCreateTableAuthorized/Ranger (known flake)
* TimestampAdvancementITest.TestUpgradeFromOlderCorruptedData
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2024 04:41:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21362 )
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/50/
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2024 01:24:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21362 )
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/50/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2024 02:28:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21362 )
Change subject: KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
......................................................................
KUDU-3570 fix use-after-free in MajorDeltaCompactionOp
This patch addresses heap-use-after-free and data race issues reported
in KUDU-3570. With this and one prior patch, neither TSAN nor ASAN
reports any warnings when running alter_table-randomized-test, at least
that's the stats collected from more than 100 iterations.
Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Reviewed-on: http://gerrit.cloudera.org:8080/21362
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
2 files changed, 15 insertions(+), 10 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I491c6d98bed8780bcfb62f152db471d7a260d305
Gerrit-Change-Number: 21362
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)