[jira] [Commented] (CLOUDSTACK-9634) fix marvin test test_router_dhcp_opts failure

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710911#comment-15710911 ] 

ASF subversion and git services commented on CLOUDSTACK-9634:
-------------------------------------------------------------

Commit b57d0ae7c34650a56c10a96c5c86105fffb3a8c3 in cloudstack's branch refs/heads/master from [~rohit.yadav@shapeblue.com]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b57d0ae ]

Merge pull request #1801 from murali-reddy/test_router_dhcp_opts

fix marvin test failure test_router_dhcp_optsmarvin, VirtualMachine object's, nic attribute does not have nic's in any
particualr order in the array. so check isdefault attribute to the get non-default nic

earlier test made assumption that nic[0] is default nic, which is not true always

* pr/1801:
  CLOUDSTACK-9634: fix marvin test failure test_router_dhcp_opts

Signed-off-by: Rohit Yadav <ro...@shapeblue.com>


> fix marvin test test_router_dhcp_opts failure
> ---------------------------------------------
>
>                 Key: CLOUDSTACK-9634
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9634
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.8.0, 4.9.0, 4.10.0.0
>            Reporter: Murali Reddy
>            Assignee: Murali Reddy
>             Fix For: 4.8.1, 4.10.0.0, 4.9.2.0
>
>
> test_router_dhcp_opts has been failing on the smoke tests on 4.8 ,4.9, 4.10. This is new test added as part of fix for "CLOUDSTACK-9598: wrong defaut gateway for the nic in non-default network"
> Marvin VirtualMachine object's nic attribute, does not store nics in any particular order. test made the assumption the  nic[0] is default nic of the virtual machine which may not necessarily true all the time
> nic objects 'isdefault' attribute can be used to verify if the nic is default nic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)