[jira] [Commented] (SENTRY-378) Clean up the usage of SentryAccessDeniedException

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613866#comment-16613866 ] 

Hadoop QA commented on SENTRY-378:
----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12876886/SENTRY-378.003.patch against master.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
error: a/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java: does not exist in index
error: a/sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java: does not exist in index
error: patch failed: sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java:256
Falling back to three-way merge...
Applied patch to 'sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java' with conflicts.
error: patch failed: sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java:31
Falling back to three-way merge...
Applied patch to 'sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java' with conflicts.
Going to apply patch with: git apply -p1
error: patch failed: sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java:256
Falling back to three-way merge...
Applied patch to 'sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java' with conflicts.
error: patch failed: sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java:31
Falling back to three-way merge...
Applied patch to 'sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java' with conflicts.
U sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
U sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java



Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4115/console

This message is automatically generated.

> Clean up the usage of SentryAccessDeniedException
> -------------------------------------------------
>
>                 Key: SENTRY-378
>                 URL: https://issues.apache.org/jira/browse/SENTRY-378
>             Project: Sentry
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Jan Hentschel
>            Priority: Minor
>         Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch, SENTRY-378.002.patch, SENTRY-378.003.patch
>
>
> SentryAccessDeniedException is mostly used when user does is not part of sentry admin group, but is trying to create role, grant role or grant privilege.  Although I see that it is also used else where, there is scope for some clean up. For example:
> SentryStore.getMSentryVersion()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)