You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/08/06 15:49:13 UTC

[GitHub] [incubator-heron] huijunwu edited a comment on pull request #3597: Clean heron-ui backend

huijunwu edited a comment on pull request #3597:
URL: https://github.com/apache/incubator-heron/pull/3597#issuecomment-670010456


   Tested on MacOs
   Some observations (not sure if they are is related to this PR, or they already existed before the PR)
   ```
   [2020-08-06 08:38:20 -0700] [INFO]: 127.0.0.1:62051 - "GET /topologies/local/default/helloworld/1/filedata?offset=-1&length=-1&path=./log-files/container_1_exclaim1_3.log.0 HTTP/1.1" 500
   [2020-08-06 08:38:20 -0700] [ERROR]: Exception in ASGI application
   Traceback (most recent call last):
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/protocols/http/httptools_impl.py", line 390, in run_asgi
       result = await app(self.scope, self.receive, self.send)
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/proxy_headers.py", line 45, in __call__
       return await self.app(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/message_logger.py", line 65, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/message_logger.py", line 61, in __call__
       await self.app(scope, inner_receive, inner_send)
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/applications.py", line 181, in __call__
       await super().__call__(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/applications.py", line 111, in __call__
       await self.middleware_stack(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/middleware/errors.py", line 181, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/middleware/errors.py", line 159, in __call__
       await self.app(scope, receive, _send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/exceptions.py", line 82, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/exceptions.py", line 71, in __call__
       await self.app(scope, receive, sender)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 566, in __call__
       await route.handle(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 227, in handle
       await self.app(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 41, in app
       response = await func(request)
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/routing.py", line 196, in app
       raw_response = await run_endpoint_function(
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/routing.py", line 149, in run_endpoint_function
       return await run_in_threadpool(dependant.call, **values)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/concurrency.py", line 34, in run_in_threadpool
       return await loop.run_in_executor(None, func, *args)
     File "/usr/local/Cellar/python@3.8/3.8.4/Frameworks/Python.framework/Versions/3.8/lib/python3.8/concurrent/futures/thread.py", line 57, in run
       result = self.fn(*self.args, **self.kwargs)
     File "/Users/huijunw/.pex/code/f640e2d8a896287a3702fc6b6996d7aca3c3d65e/heron/tools/ui/src/python/main.py", line 290, in file_data
       return Response(content=data, media_type="application/binary")
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/responses.py", line 49, in __init__
       self.body = self.render(content)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/responses.py", line 57, in render
       return content.encode(self.charset)
   AttributeError: 'dict' object has no attribute 'encode'
   
   ```
   
   ![Screen Shot 2020-08-06 at 8 40 22 AM](https://user-images.githubusercontent.com/4208547/89552137-9d3dff00-d7c0-11ea-9318-f6a1d83d5df7.png)
   
   ![Screen Shot 2020-08-06 at 8 41 53 AM](https://user-images.githubusercontent.com/4208547/89552212-b777dd00-d7c0-11ea-8f6e-529ba99ae88e.png)
   
   ```
   [2020-08-06 08:43:49 -0700] [ERROR]: Unable to get response from http://127.0.0.1:8888/topologies/pid: 404 Client Error: Not Found for url: http://127.0.0.1:8888/topologies/pid?cluster=local&environ=default&topology=helloworld&instance=container_2_word_6
   [2020-08-06 08:43:49 -0700] [INFO]: 127.0.0.1:62832 - "GET /topologies/local/default/helloworld/container_2_word_6/pid HTTP/1.1" 500
   [2020-08-06 08:43:49 -0700] [ERROR]: Exception in ASGI application
   Traceback (most recent call last):
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/protocols/http/httptools_impl.py", line 390, in run_asgi
       result = await app(self.scope, self.receive, self.send)
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/proxy_headers.py", line 45, in __call__
       return await self.app(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/message_logger.py", line 65, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/6cd94f24fe549f5f278fef0989ec1818c8c82eb7/uvicorn-0.11.7-py3-none-any.whl/uvicorn/middleware/message_logger.py", line 61, in __call__
       await self.app(scope, inner_receive, inner_send)
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/applications.py", line 181, in __call__
       await super().__call__(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/applications.py", line 111, in __call__
       await self.middleware_stack(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/middleware/errors.py", line 181, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/middleware/errors.py", line 159, in __call__
       await self.app(scope, receive, _send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/exceptions.py", line 82, in __call__
       raise exc from None
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/exceptions.py", line 71, in __call__
       await self.app(scope, receive, sender)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 566, in __call__
       await route.handle(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 227, in handle
       await self.app(scope, receive, send)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/routing.py", line 41, in app
       response = await func(request)
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/routing.py", line 196, in app
       raw_response = await run_endpoint_function(
     File "/Users/huijunw/.pex/installed_wheels/18b4a830bde6aa705858d31555dbe1aea1e917c3/fastapi-0.60.1-py3-none-any.whl/fastapi/routing.py", line 149, in run_endpoint_function
       return await run_in_threadpool(dependant.call, **values)
     File "/Users/huijunw/.pex/installed_wheels/5d659e4c2dba112a90305109923229b0159343b9/starlette-0.13.6-py3-none-any.whl/starlette/concurrency.py", line 34, in run_in_threadpool
       return await loop.run_in_executor(None, func, *args)
     File "/usr/local/Cellar/python@3.8/3.8.4/Frameworks/Python.framework/Versions/3.8/lib/python3.8/concurrent/futures/thread.py", line 57, in run
       result = self.fn(*self.args, **self.kwargs)
     File "/Users/huijunw/.pex/code/f640e2d8a896287a3702fc6b6996d7aca3c3d65e/heron/tools/ui/src/python/main.py", line 464, in pid_snippet
       command = info["command"]
   TypeError: 'NoneType' object is not subscriptable
   
   ```
   
   
   ![Screen Shot 2020-08-06 at 8 43 42 AM](https://user-images.githubusercontent.com/4208547/89552509-163d5680-d7c1-11ea-86cf-ed79fc63d650.png)
   
   
   ![Screen Shot 2020-08-06 at 8 43 55 AM](https://user-images.githubusercontent.com/4208547/89552521-1a697400-d7c1-11ea-9454-6b798547c442.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org