You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/26 00:50:47 UTC
[GitHub] [skywalking-eyes] kezhenxu94 opened a new pull request #11: Shape the quality-eye sub-directory for NGE2E
kezhenxu94 opened a new pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11
This patch creates a sub-directory to host the new E2E framework codes, @fgksgf @Humbertzhang , let's host the codes here instead of in the CLI repo, they are independent after all.
@wu-sheng this also demonstrates how we organize different tools in this repo, we may have "release-eye" (checking gpg / sha512, etc.) in the future that stands alongside "license-eye", "quality-eye", etc.. Hope the structures make sense to you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #11: Shape the quality-eye sub-directory for NGE2E
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11#discussion_r548930311
##########
File path: quality-eye/README.md
##########
@@ -0,0 +1,5 @@
+# Quality Eye - NGE2E
+
+NGE2E is the next generation End-to-End Testing framework that aims to help developers to set up, debug, and verify E2E tests with ease. It’s built based on the lessons learnt from tens of hundreds of test cases in the SkyWalking main repo.
Review comment:
From the validation part, https://skywalking.apache.org/blog/e2e-design/#verify, this is not a common usage e2e test tool.
Do you plan to expand the scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #11: Shape the quality-eye sub-directory for NGE2E
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11#discussion_r548930941
##########
File path: quality-eye/README.md
##########
@@ -0,0 +1,5 @@
+# Quality Eye - NGE2E
+
+NGE2E is the next generation End-to-End Testing framework that aims to help developers to set up, debug, and verify E2E tests with ease. It’s built based on the lessons learnt from tens of hundreds of test cases in the SkyWalking main repo.
Review comment:
[This](https://github.com/apache/skywalking-website/pull/184) should address your question
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #11: Shape the quality-eye sub-directory for NGE2E
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on pull request #11: Shape the quality-eye sub-directory for NGE2E
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11#issuecomment-751306687
I don't have any concern about the structure from the beginning. The thing I wanted to point out is it will become a factor to determine when to release.
Because your git tag needs to match the apache source tar. But as the monorepo, it is very hard, or impossible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on pull request #11: Shape the quality-eye sub-directory for NGE2E
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #11:
URL: https://github.com/apache/skywalking-eyes/pull/11#issuecomment-751307470
We definitely could have multiple tools in every release, but basically, please make sure all tools are available in every release(git tag).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org