[GitHub] jerrypeng commented on a change in pull request #1681: additional refactoring to use source interface

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #1681: additional refactoring to use source interface
URL: https://github.com/apache/incubator-pulsar/pull/1681#discussion_r184872234
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
 ##########
 @@ -699,6 +707,9 @@ private void validateTriggerRequestParams(String tenant,
         if (functionName == null) {
             throw new IllegalArgumentException("Function Name is not provided");
         }
+        if (topic == null) {
 
 Review comment:
   sure we can add that, but since there are already a big number of changes, lets do that in a subsequent PR.  Lets first just get the basics in place 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services