You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/03 19:45:00 UTC

[jira] [Work logged] (BEAM-6441) cut_release_branch.sh should not push to master without verification and a PR

     [ https://issues.apache.org/jira/browse/BEAM-6441?focusedWorklogId=429973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429973 ]

ASF GitHub Bot logged work on BEAM-6441:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/May/20 19:44
            Start Date: 03/May/20 19:44
    Worklog Time Spent: 10m 
      Work Description: stale[bot] commented on pull request #8223:
URL: https://github.com/apache/beam/pull/8223#issuecomment-623169519


   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 429973)
    Time Spent: 3h 20m  (was: 3h 10m)

> cut_release_branch.sh should not push to master without verification and a PR
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-6441
>                 URL: https://issues.apache.org/jira/browse/BEAM-6441
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Currently, the cut_release_branch.sh does many things:
>  - Edits files in place to update the version
>  - Makes a local commit
>  - Pushing the local commit to master
>  - Creates a new branch
>  - Edits files in place to update the version
>  - Pushes the release branch
> I think all of this except the push to master are OK. It is possible that we have something - website, examples, new places where the version is hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch creation does not need to be synchronized with this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)