[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r587431276



##########
File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java
##########
@@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector decorate(MultiValueDimensionVectorSele
     throw new UOE("DimensionSpec[%s] cannot vectorize", getClass().getName());
   }
 
+  default VectorObjectSelector decorate(VectorObjectSelector selector)

Review comment:
       I've removed the `decorate` method I added in this PR, in favor of removing this functionality from the vectorized engine. Since no `decorate`, no need for a separate "object dimension selector", I've removed that from `VectorColumnSelectorFactory` as well and reverted the signatures changes to processors that were needed to support that :+1:
   
   If we do the same thing and ditch `decorate` for `SingleValueDimensionVectorSelector` and `MultiValueDimensionVectorSelector` there is quite a bit of simplification we can do, because we can discard the `DimensionSpec` much earlier and just work with `columnName` like the other selectors instead of going all the way down like it does now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org