You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/14 21:25:28 UTC

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10719


Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation
......................................................................

IMPALA-7174: xfail test_admission_controller.test_cancellation

XFAIL for now if we hit an exception until we can figure out
the cause of the flakiness.

Testing:
Added a bogus exception, made sure that the test got xfailed correctly.
Ensured that the test passes normally when we're not in a flaky case.

Change-Id: I4567fe11ffd482156286f6c657b3cdcf09600ae0
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/10719/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4567fe11ffd482156286f6c657b3cdcf09600ae0
Gerrit-Change-Number: 10719
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10719 )

Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation
......................................................................


Abandoned

Replaced with the actual fix.
-- 
To view, visit http://gerrit.cloudera.org:8080/10719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4567fe11ffd482156286f6c657b3cdcf09600ae0
Gerrit-Change-Number: 10719
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10719 )

Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation
......................................................................


Patch Set 2:

I'm pretty sure I figured out the root cause of the test failure. I'll let this merge job continue but will push out the follow-on patch once I've confirmed that it works.


-- 
To view, visit http://gerrit.cloudera.org:8080/10719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4567fe11ffd482156286f6c657b3cdcf09600ae0
Gerrit-Change-Number: 10719
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 22:05:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7174: xfail test admission controller.test cancellation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10719 )

Change subject: IMPALA-7174: xfail test_admission_controller.test_cancellation
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2677/


-- 
To view, visit http://gerrit.cloudera.org:8080/10719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4567fe11ffd482156286f6c657b3cdcf09600ae0
Gerrit-Change-Number: 10719
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 21:25:47 +0000
Gerrit-HasComments: No