You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "karensmolermiller (GitHub)" <gi...@apache.org> on 2018/10/15 15:52:10 UTC
[GitHub] [geode] karensmolermiller opened pull request #2605:
GEODE-5845 Document not to use enums for keys
@Bill Review, please.
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on pull request #2605:
GEODE-5845 Document not to use enums for keys
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Also, since we are stressing that hashCode must return the same value across servers, maybe we should also mention that equals should return the same result on different servers as well?
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on pull request #2605:
GEODE-5845 Document not to use enums for keys
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Maybe this should just say - do not *call* `hashCode` on an `Enum` in your `hashCode` method? You can *use* an enum, but you'll have to come up with your own way of hashing it.
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Bill commented on issue #2605: GEODE-5845 Document
not to use enums for keys
Posted by "Bill (GitHub)" <gi...@apache.org>.
These changes are perfectly clear ✓
Only suggestion I have is to consistently put parenthesis with the method name when referring to `hashCode()` as a method. When referring to the general concept, I suggest using the compound noun "hash code".
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] karensmolermiller closed pull request #2605:
GEODE-5845 Document not to use enums for keys
Posted by "karensmolermiller (GitHub)" <gi...@apache.org>.
[ pull request closed by karensmolermiller ]
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on pull request #2605:
GEODE-5845 Document not to use enums for keys
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
This comment about hashcodes is a little confusing - it sounds like no duplicate hashcodes are permitted, which is not true. What are we trying to tell the user about their hashCode method here?
[ Full content available at: https://github.com/apache/geode/pull/2605 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org