[jira] [Resolved] (SPARK-6303) Remove unnecessary Average in GeneratedAggregate

["Michael Armbrust (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Armbrust resolved SPARK-6303.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.4.0

Issue resolved by pull request 4996
[https://github.com/apache/spark/pull/4996]

> Remove unnecessary Average in GeneratedAggregate
> ------------------------------------------------
>
>                 Key: SPARK-6303
>                 URL: https://issues.apache.org/jira/browse/SPARK-6303
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Liang-Chi Hsieh
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Because {{Average}} is a {{PartialAggregate}}, we never get a {{Average}} node when reaching {{HashAggregation}} to prepare {{GeneratedAggregate}}.
> That is why in SQLQuerySuite there is already a test for {{avg}} with codegen. And it works.
> But we can find a case in {{GeneratedAggregate}} to deal with {{Average}}. Based on the above, we actually never execute this case.
> So we can remove this case from {{GeneratedAggregate}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org