You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/06/22 12:36:40 UTC
Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4297
https://issues.apache.org/jira/browse/RANGER-4297
Repository: ranger
Description
-------
Steps to reproduce:-
1)Create a user.
2)After creating the user it will go to last page of the table.
3)But it does not scroll to that newly created user
Current behaviour:
Not get scrolled to newly added row in listing tables
Expected behaviour:
User should be scroll to newly added row in listing tables
The last response time is not updated in service manager page when importing or export the policies.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx 7fe756c47
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx e3ba45f0e
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx 49edc2861
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx 77797f966
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx d835bfad1
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx 44346bb4b
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx b77c0fe73
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx 86059c463
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 4e1fc9205
Diff: https://reviews.apache.org/r/74489/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in policy & user/group/role module.
2)policy & user/group/role listing pages.
3)The last response time is updating when importing or exporting the policies in service manager page
Thanks,
Brijesh Bhalala
Re: Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/#review225598
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On July 10, 2023, 11:16 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74489/
> -----------------------------------------------------------
>
> (Updated July 10, 2023, 11:16 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4297
> https://issues.apache.org/jira/browse/RANGER-4297
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to reproduce:-
> 1)Create a user.
> 2)After creating the user it will go to last page of the table.
> 3)But it does not scroll to that newly created user
>
> Current behaviour:
> Not get scrolled to newly added row in listing tables
>
> Expected behaviour:
> User should be scroll to newly added row in listing tables
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx c2aa0a018
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx efe0435b6
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx f705ee8ce
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx a6ee46413
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 625e5d1c1
>
>
> Diff: https://reviews.apache.org/r/74489/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in policy & user/group/role module.
> 2)policy & user/group/role listing pages.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/
-----------------------------------------------------------
(Updated July 10, 2023, 11:16 a.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4297
https://issues.apache.org/jira/browse/RANGER-4297
Repository: ranger
Description (updated)
-------
Steps to reproduce:-
1)Create a user.
2)After creating the user it will go to last page of the table.
3)But it does not scroll to that newly created user
Current behaviour:
Not get scrolled to newly added row in listing tables
Expected behaviour:
User should be scroll to newly added row in listing tables
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx c2aa0a018
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx efe0435b6
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx f705ee8ce
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx a6ee46413
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 625e5d1c1
Diff: https://reviews.apache.org/r/74489/diff/2/
Testing (updated)
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in policy & user/group/role module.
2)policy & user/group/role listing pages.
Thanks,
Brijesh Bhalala
Re: Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/#review225597
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On July 10, 2023, 11:08 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74489/
> -----------------------------------------------------------
>
> (Updated July 10, 2023, 11:08 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4297
> https://issues.apache.org/jira/browse/RANGER-4297
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to reproduce:-
> 1)Create a user.
> 2)After creating the user it will go to last page of the table.
> 3)But it does not scroll to that newly created user
>
> Current behaviour:
> Not get scrolled to newly added row in listing tables
>
> Expected behaviour:
> User should be scroll to newly added row in listing tables
>
> The last response time is not updated in service manager page when importing or export the policies.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx c2aa0a018
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx efe0435b6
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx f705ee8ce
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx a6ee46413
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 625e5d1c1
>
>
> Diff: https://reviews.apache.org/r/74489/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in policy & user/group/role module.
> 2)policy & user/group/role listing pages.
> 3)The last response time is updating when importing or exporting the policies in service manager page
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/
-----------------------------------------------------------
(Updated July 10, 2023, 11:08 a.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4297
https://issues.apache.org/jira/browse/RANGER-4297
Repository: ranger
Description
-------
Steps to reproduce:-
1)Create a user.
2)After creating the user it will go to last page of the table.
3)But it does not scroll to that newly created user
Current behaviour:
Not get scrolled to newly added row in listing tables
Expected behaviour:
User should be scroll to newly added row in listing tables
The last response time is not updated in service manager page when importing or export the policies.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx c2aa0a018
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx efe0435b6
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx f705ee8ce
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx a6ee46413
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 625e5d1c1
Diff: https://reviews.apache.org/r/74489/diff/2/
Changes: https://reviews.apache.org/r/74489/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in policy & user/group/role module.
2)policy & user/group/role listing pages.
3)The last response time is updating when importing or exporting the policies in service manager page
Thanks,
Brijesh Bhalala
Re: Review Request 74489: RANGER-4297: Scroll to Newly added row functionality in listing tables is not working.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74489/#review225565
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On June 22, 2023, 12:36 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74489/
> -----------------------------------------------------------
>
> (Updated June 22, 2023, 12:36 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4297
> https://issues.apache.org/jira/browse/RANGER-4297
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Steps to reproduce:-
> 1)Create a user.
> 2)After creating the user it will go to last page of the table.
> 3)But it does not scroll to that newly created user
>
> Current behaviour:
> Not get scrolled to newly added row in listing tables
>
> Expected behaviour:
> User should be scroll to newly added row in listing tables
>
> The last response time is not updated in service manager page when importing or export the policies.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx 7fe756c47
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx e3ba45f0e
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx 49edc2861
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx 77797f966
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx d835bfad1
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx 44346bb4b
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx b77c0fe73
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx 86059c463
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 4e1fc9205
>
>
> Diff: https://reviews.apache.org/r/74489/diff/1/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in policy & user/group/role module.
> 2)policy & user/group/role listing pages.
> 3)The last response time is updating when importing or exporting the policies in service manager page
>
>
> Thanks,
>
> Brijesh Bhalala
>
>