You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/24 03:40:13 UTC

[GitHub] [servicecomb-service-center] ChinX opened a new pull request #611: [SCB-1681] SC-Client supports the full contract API

ChinX opened a new pull request #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] MabinGo commented on a change in pull request #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
MabinGo commented on a change in pull request #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#discussion_r361347611
 
 

 ##########
 File path: pkg/client/sc/schemas.go
 ##########
 @@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package sc
+
+import (
+	"context"
+	"crypto/sha256"
+	"encoding/json"
+	"fmt"
+	"github.com/apache/servicecomb-service-center/pkg/log"
 
 Review comment:
   Please format the code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] MabinGo merged pull request #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
MabinGo merged pull request #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io commented on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646350
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=h1) Report
   > Merging [#611](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/a85de206b075033df408bd2d599b32d811dab315?src=pr&el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #611      +/-   ##
   ==========================================
   - Coverage   57.75%   57.56%   -0.19%     
   ==========================================
     Files         204      205       +1     
     Lines       15709    15777      +68     
   ==========================================
   + Hits         9072     9082      +10     
   - Misses       5986     6046      +60     
   + Partials      651      649       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/sc/apis.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9hcGlzLmdv) | `0% <ø> (ø)` | :arrow_up: |
   | [pkg/client/sc/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9pbnN0YW5jZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | [pkg/client/sc/schemas.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9zY2hlbWFzLmdv) | `0% <0%> (ø)` | |
   | [syncer/pkg/utils/files.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9maWxlcy5nbw==) | `86.66% <0%> (-6.67%)` | :arrow_down: |
   | [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `53.57% <0%> (-0.72%)` | :arrow_down: |
   | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
   | [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `73.8% <0%> (+2.38%)` | :arrow_up: |
   | [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `67.74% <0%> (+3.22%)` | :arrow_up: |
   | [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `72.72% <0%> (+9.09%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=footer). Last update [a85de20...94184b1](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646350
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=h1) Report
   > Merging [#611](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/a85de206b075033df408bd2d599b32d811dab315?src=pr&el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #611      +/-   ##
   ==========================================
   - Coverage   57.75%   57.52%   -0.23%     
   ==========================================
     Files         204      205       +1     
     Lines       15709    15777      +68     
   ==========================================
   + Hits         9072     9076       +4     
   - Misses       5986     6054      +68     
   + Partials      651      647       -4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/sc/apis.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9hcGlzLmdv) | `0% <ø> (ø)` | :arrow_up: |
   | [pkg/client/sc/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9pbnN0YW5jZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | [pkg/client/sc/schema.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9zY2hlbWEuZ28=) | `0% <0%> (ø)` | |
   | [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `53.57% <0%> (-0.72%)` | :arrow_down: |
   | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
   | [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `81.14% <0%> (+0.57%)` | :arrow_up: |
   | [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `73.8% <0%> (+2.38%)` | :arrow_up: |
   | [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `59.45% <0%> (+2.7%)` | :arrow_up: |
   | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=footer). Last update [a85de20...690a674](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646312
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27793502/badge)](https://coveralls.io/builds/27793502)
   
   Coverage decreased (-0.3%) to 59.925% when pulling **690a674386038be89775b8136493c0e450d87e9b on ChinX:master** into **a85de206b075033df408bd2d599b32d811dab315 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] MabinGo commented on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
MabinGo commented on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568983386
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646312
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27794696/badge)](https://coveralls.io/builds/27794696)
   
   Coverage decreased (-0.1%) to 60.04% when pulling **4f23ef94668fef810d03fa5e4f701f676e1a02b3 on ChinX:master** into **a85de206b075033df408bd2d599b32d811dab315 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646350
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=h1) Report
   > Merging [#611](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/a85de206b075033df408bd2d599b32d811dab315?src=pr&el=desc) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #611      +/-   ##
   =========================================
   - Coverage   57.75%   57.6%   -0.16%     
   =========================================
     Files         204     205       +1     
     Lines       15709   15776      +67     
   =========================================
   + Hits         9072    9087      +15     
   - Misses       5986    6041      +55     
   + Partials      651     648       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/sc/apis.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9hcGlzLmdv) | `0% <ø> (ø)` | :arrow_up: |
   | [pkg/client/sc/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9pbnN0YW5jZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
   | [pkg/client/sc/schema.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL2NsaWVudC9zYy9zY2hlbWEuZ28=) | `0% <0%> (ø)` | |
   | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
   | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `55.85% <0%> (+0.15%)` | :arrow_up: |
   | [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `70.72% <0%> (+0.15%)` | :arrow_up: |
   | [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `73.8% <0%> (+2.38%)` | :arrow_up: |
   | [syncer/serf/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvY29uZmlnLmdv) | `59.45% <0%> (+2.7%)` | :arrow_up: |
   | [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `67.74% <0%> (+3.22%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/611/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=footer). Last update [a85de20...4f23ef9](https://codecov.io/gh/apache/servicecomb-service-center/pull/611?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls commented on issue #611: [SCB-1681] SC-Client supports the full contract API

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #611: [SCB-1681] SC-Client supports the full contract API
URL: https://github.com/apache/servicecomb-service-center/pull/611#issuecomment-568646312
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27776289/badge)](https://coveralls.io/builds/27776289)
   
   Coverage decreased (-0.2%) to 59.995% when pulling **94184b1cde7d21d27cce3bb599d586378c445a41 on ChinX:master** into **a85de206b075033df408bd2d599b32d811dab315 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services