You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2024/02/05 05:25:28 UTC
[PR] [FLINK-32747][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
1996fanrui opened a new pull request, #24266:
URL: https://github.com/apache/flink/pull/24266
## What is the purpose of the change
https://github.com/apache/flink/pull/24251 improved a series of documentations related to `flink-configuration-file.`. But it has 2 issues:
- All `flink-configuration-file ` links in Chinese doc are wrong
- The suffix should be `#flink-配置文件` instead of `#flink-configuration-file`
- Some sentences already has `file` or `flink-configuration-file`. And the link title is `flink-configuration-file` as well. They are repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34247][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #24266:
URL: https://github.com/apache/flink/pull/24266#discussion_r1477680165
##########
docs/content.zh/docs/ops/state/state_backends.md:
##########
@@ -288,11 +288,11 @@ RocksDB State Backend 会将 [这里定义]({{< ref "docs/deployment/config" >}}
有两种方法可以将 `RocksDBOptionsFactory` 传递给 RocksDB State Backend：
- - 通过 `state.backend.rocksdb.options-factory` 选项将工厂实现类的名称设置到[Flink 配置文件]({{< ref "docs/deployment/config#flink-configuration-file" >}}) 。
+ - 通过 `state.backend.rocksdb.options-factory` 选项将工厂实现类的名称设置到[Flink 配置文件]({{< ref "docs/deployment/config#flink-配置文件" >}}) 。
- 通过程序设置，例如 `EmbeddedRocksDBStateBackend.setRocksDBOptions(new MyOptionsFactory());` 。
-<span class="label label-info">注意</span> 通过程序设置的 `RocksDBOptionsFactory` 将覆盖 [Flink 配置文件]({{< ref "docs/deployment/config#flink-configuration-file" >}}) 配置文件的设置，且 `RocksDBOptionsFactory` 设置的优先级高于预定义选项（`PredefinedOptions`）。
+<span class="label label-info">注意</span> 通过程序设置的 `RocksDBOptionsFactory` 将覆盖 [Flink 配置文件]({{< ref "docs/deployment/config#flink-配置文件" >}}) 的设置，且 `RocksDBOptionsFactory` 设置的优先级高于预定义选项（`PredefinedOptions`）。
Review Comment:
Here is an example of issue 2, the `配置文件的设置` should be changed to `的设置`。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34247][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee commented on code in PR #24266:
URL: https://github.com/apache/flink/pull/24266#discussion_r1477726463
##########
docs/content.zh/docs/deployment/resource-providers/standalone/docker.md:
##########
@@ -534,7 +534,7 @@ To provide a custom location for the Flink configuration files, you can
{{< hint info >}}
The mounted volume must contain all necessary configuration files.
-The [Flink configuration file]({{< ref "docs/deployment/config#flink-configuration-file" >}}) file must have write permission so that the Docker entry point script can modify it in certain cases.
+The [Flink configuration file]({{< ref "docs/deployment/config#flink-配置文件" >}}) file must have write permission so that the Docker entry point script can modify it in certain cases.
Review Comment:
```suggestion
The [Flink configuration file]({{< ref "docs/deployment/config#flink-配置文件" >}}) must have write permission so that the Docker entry point script can modify it in certain cases.
```
##########
docs/content/docs/deployment/resource-providers/yarn.md:
##########
@@ -151,7 +151,7 @@ You can **re-attach to a YARN session** using the following command:
./bin/yarn-session.sh -id application_XXXX_YY
```
-Besides passing [configuration]({{< ref "docs/deployment/config" >}}) via the [Flink configuration file]({{< ref "docs/deployment/config#flink-configuration-file" >}}) file, you can also pass any configuration at submission time to the `./bin/yarn-session.sh` client using `-Dkey=value` arguments.
+Besides passing [configuration]({{< ref "docs/deployment/config" >}}) via the [Flink configuration file]({{< ref "docs/deployment/config#flink-configuration-file" >}}) , you can also pass any configuration at submission time to the `./bin/yarn-session.sh` client using `-Dkey=value` arguments.
Review Comment:
```suggestion
Besides passing [configuration]({{< ref "docs/deployment/config" >}}) via the [Flink configuration file]({{< ref "docs/deployment/config#flink-configuration-file" >}}), you can also pass any configuration at submission time to the `./bin/yarn-session.sh` client using `-Dkey=value` arguments.
```
##########
docs/content.zh/docs/deployment/resource-providers/standalone/overview.md:
##########
@@ -82,11 +82,11 @@ cd flink-*
### 配置 Flink
-在解压完文件后，你需要编辑 [*Flink 配置文件*]({{< ref "docs/deployment/config#flink-configuration-file" >}})来为集群配置 Flink。
+在解压完文件后，你需要编辑 [*Flink 配置文件*]({{< ref "docs/deployment/config#flink-配置文件" >}})来为集群配置 Flink。
设置 `jobmanager.rpc.address` 配置项指向 master 节点。你也应该通过设置 `jobmanager.memory.process.size` 和 `taskmanager.memory.process.size` 配置项来定义 Flink 允许在每个节点上分配的最大内存值。
-这些值的单位是 MB。如果一些 worker 节点上有你想分配到 Flink 系统的多余内存，你可以在这些特定节点的 [*Flink 配置文件*]({{< ref "docs/deployment/config#flink-configuration-file" >}}) 文件中重写 `taskmanager.memory.process.size` 或 `taskmanager.memory.flink.size` 的默认值。
+这些值的单位是 MB。如果一些 worker 节点上有你想分配到 Flink 系统的多余内存，你可以在这些特定节点的 [*Flink 配置文件*]({{< ref "docs/deployment/config#flink-配置文件" >}}) 文件中重写 `taskmanager.memory.process.size` 或 `taskmanager.memory.flink.size` 的默认值。
Review Comment:
```suggestion
这些值的单位是 MB。如果一些 worker 节点上有你想分配到 Flink 系统的多余内存，你可以在这些特定节点的 [*Flink 配置文件*]({{< ref "docs/deployment/config#flink-配置文件" >}}) 中重写 `taskmanager.memory.process.size` 或 `taskmanager.memory.flink.size` 的默认值。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32747][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #24266:
URL: https://github.com/apache/flink/pull/24266#discussion_r1477680165
##########
docs/content.zh/docs/ops/state/state_backends.md:
##########
@@ -288,11 +288,11 @@ RocksDB State Backend 会将 [这里定义]({{< ref "docs/deployment/config" >}}
有两种方法可以将 `RocksDBOptionsFactory` 传递给 RocksDB State Backend：
- - 通过 `state.backend.rocksdb.options-factory` 选项将工厂实现类的名称设置到[Flink 配置文件]({{< ref "docs/deployment/config#flink-configuration-file" >}}) 。
+ - 通过 `state.backend.rocksdb.options-factory` 选项将工厂实现类的名称设置到[Flink 配置文件]({{< ref "docs/deployment/config#flink-配置文件" >}}) 。
- 通过程序设置，例如 `EmbeddedRocksDBStateBackend.setRocksDBOptions(new MyOptionsFactory());` 。
-<span class="label label-info">注意</span> 通过程序设置的 `RocksDBOptionsFactory` 将覆盖 [Flink 配置文件]({{< ref "docs/deployment/config#flink-configuration-file" >}}) 配置文件的设置，且 `RocksDBOptionsFactory` 设置的优先级高于预定义选项（`PredefinedOptions`）。
+<span class="label label-info">注意</span> 通过程序设置的 `RocksDBOptionsFactory` 将覆盖 [Flink 配置文件]({{< ref "docs/deployment/config#flink-配置文件" >}}) 的设置，且 `RocksDBOptionsFactory` 设置的优先级高于预定义选项（`PredefinedOptions`）。
Review Comment:
Here is issue 2, the `配置文件的设置` should be changed to `的设置`。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34247][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24266:
URL: https://github.com/apache/flink/pull/24266#issuecomment-1926262061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6def6ebc69b0b6568eec6897327e5d8aaa667110",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6def6ebc69b0b6568eec6897327e5d8aaa667110",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6def6ebc69b0b6568eec6897327e5d8aaa667110 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34247][doc] Fix the wrong zh link for flink-configuration-file and repeated flink configuration file [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #24266:
URL: https://github.com/apache/flink/pull/24266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org