You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Miguel Ferreira <mi...@me.com> on 2014/02/14 12:02:41 UTC
Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
Fix findbugs findings in cloud-plugin-network-elb
Findings:
- comparing Longs by reference
- possible null pointer dereference
Diffs
-----
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8b4433e
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 6dd0f8a
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/18113/diff/
Testing
-------
Added unit tests the changes in the patch and tested in DevCloud.
Thanks,
Miguel Ferreira
Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/#review34491
-----------------------------------------------------------
Ship it!
commit 9903b44754da7188dd5cb277357c57c83c1b3ebe
Author: Miguel Ferreira <mf...@shubergphilis.com>
Date: Mon Feb 10 20:05:23 2014 +0100
Fix findbugs findings in cloud-plugin-network-elb
Findings:
- comparing Longs by reference
- possible null pointer dereference
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Feb. 14, 2014, 2:38 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18113/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 2:38 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix findbugs findings in cloud-plugin-network-elb
>
> Findings:
> - comparing Longs by reference
> - possible null pointer dereference
>
>
> Diffs
> -----
>
> plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 6dd0f8a
> plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java PRE-CREATION
> plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java PRE-CREATION
> plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18113/diff/
>
>
> Testing
> -------
>
> Added unit tests the changes in the patch and tested in DevCloud.
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb
Posted by Miguel Ferreira <mi...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/
-----------------------------------------------------------
(Updated Feb. 14, 2014, 2:38 p.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Previous patch was rebased on the wrong brnach which lead to unintended merges.
This update cleans that up.
Repository: cloudstack-git
Description
-------
Fix findbugs findings in cloud-plugin-network-elb
Findings:
- comparing Longs by reference
- possible null pointer dereference
Diffs (updated)
-----
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 6dd0f8a
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/18113/diff/
Testing
-------
Added unit tests the changes in the patch and tested in DevCloud.
Thanks,
Miguel Ferreira
Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb
Posted by Miguel Ferreira <mi...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/
-----------------------------------------------------------
(Updated Feb. 14, 2014, 11:48 a.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Add license headers to new files
Repository: cloudstack-git
Description
-------
Fix findbugs findings in cloud-plugin-network-elb
Findings:
- comparing Longs by reference
- possible null pointer dereference
Diffs (updated)
-----
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8b4433e
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 6dd0f8a
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/18113/diff/
Testing
-------
Added unit tests the changes in the patch and tested in DevCloud.
Thanks,
Miguel Ferreira