[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16837: [fix][client]Fix client memory limit currentUsage leak and semaphore release duplicated in ProducerImpl

[GitBox <gi...@apache.org>]

Technoboy- commented on code in PR #16837:
URL: https://github.com/apache/pulsar/pull/16837#discussion_r932936068


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -2113,10 +2115,8 @@ private void batchMessageAndSend(boolean shouldScheduleNextBatchFlush) {
                 for (OpSendMsg opSendMsg : opSendMsgs) {
                     processOpSendMsg(opSendMsg);
                 }
-            } catch (PulsarClientException e) {
-                semaphoreRelease(batchMessageContainer.getNumMessagesInBatch());
             } catch (Throwable t) {
-                semaphoreRelease(batchMessageContainer.getNumMessagesInBatch());
+                // Nothing to do.

Review Comment:
   We can remove this comment...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org