[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #26968: Fix sla checks being skipped when the preceding task instance misses the sla

[GitBox <gi...@apache.org>]

ephraimbuddy commented on code in PR #26968:
URL: https://github.com/apache/airflow/pull/26968#discussion_r1012932975


##########
airflow/dag_processing/processor.py:
##########
@@ -425,7 +425,7 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:
                 if next_info is None:
                     break
                 if (ti.dag_id, ti.task_id, next_info.logical_date) in recorded_slas_query:
-                    break
+                    continue

Review Comment:
   This seems like a change in behaviour. It seems like it's going to record too many SLAs this way. 
   cc: @ashb 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org