You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/12/13 17:28:43 UTC
Review Request 41326: Fixed error in authentication cleanup function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41326/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
Repository: mesos
Description
-------
When a process is destroyed, it deregisters all its endpoints from authentication. However the paths were malformed and the endpoints were left inside the authentication router.
Diffs
-----
3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
Diff: https://reviews.apache.org/r/41326/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 41326: Fixed error in authentication cleanup
function.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41326/#review110182
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41326]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 13, 2015, 4:28 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41326/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 4:28 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a process is destroyed, it deregisters all its endpoints from authentication. However the paths were malformed and the endpoints were left inside the authentication router.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
>
> Diff: https://reviews.apache.org/r/41326/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 41326: Fixed error in authentication cleanup
function.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41326/#review110209
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Dec. 13, 2015, 8:28 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41326/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 8:28 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a process is destroyed, it deregisters all its endpoints from authentication. However the paths were malformed and the endpoints were left inside the authentication router.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
>
> Diff: https://reviews.apache.org/r/41326/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 41326: Fixed error in authentication cleanup
function.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41326/#review110235
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Dec. 13, 2015, 4:28 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41326/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2015, 4:28 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a process is destroyed, it deregisters all its endpoints from authentication. However the paths were malformed and the endpoints were left inside the authentication router.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp af3cefb59c506863959bf80aedb27ea5d22d7b74
>
> Diff: https://reviews.apache.org/r/41326/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>