You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:01:24 UTC
[GitHub] [servicecomb-java-chassis] zhaozw opened a new pull request, #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
zhaozw opened a new pull request, #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#discussion_r930540853
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/IsolationDiscoveryFilter.java:
##########
@@ -42,17 +39,15 @@
/**
* Isolate instances by error metrics
*/
-public class IsolationDiscoveryFilter implements DiscoveryFilter {
-
- public static final String TRYING_INSTANCES_EXISTING = "scb-hasTryingInstances";
+public class IsolationDiscoveryFilter implements ServerListFilterExt {
private static final Logger LOGGER = LoggerFactory.getLogger(IsolationDiscoveryFilter.class);
- private static final String EMPTY_INSTANCE_PROTECTION = "servicecomb.loadbalance.filter.isolation.emptyInstanceProtectionEnabled";
-
private final DynamicBooleanProperty emptyProtection = DynamicPropertyFactory.getInstance()
.getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
+ public EventBus eventBus = EventManager.getEventBus();
Review Comment:
use private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3223: [SCB-2643]fix instance isolation filter not work problem
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#discussion_r930546431
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/filterext/IsolationDiscoveryFilter.java:
##########
@@ -42,17 +39,15 @@
/**
* Isolate instances by error metrics
*/
-public class IsolationDiscoveryFilter implements DiscoveryFilter {
-
- public static final String TRYING_INSTANCES_EXISTING = "scb-hasTryingInstances";
+public class IsolationDiscoveryFilter implements ServerListFilterExt {
private static final Logger LOGGER = LoggerFactory.getLogger(IsolationDiscoveryFilter.class);
- private static final String EMPTY_INSTANCE_PROTECTION = "servicecomb.loadbalance.filter.isolation.emptyInstanceProtectionEnabled";
-
private final DynamicBooleanProperty emptyProtection = DynamicPropertyFactory.getInstance()
.getBooleanProperty(EMPTY_INSTANCE_PROTECTION, false);
+ public EventBus eventBus = EventManager.getEventBus();
Review Comment:
can we mark this field final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#discussion_r929717290
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/ServerListFilterExt.java:
##########
@@ -29,7 +29,7 @@
*/
public interface ServerListFilterExt {
default int getOrder() {
- return 0;
+ return FilterConstant.ORDER_NORMAL;
Review Comment:
Do not change default value. ORDER_NORMAL should be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#issuecomment-1195250434
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3223](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fd38b6) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/f2a7b61a823301c59f42d93276bffcfa541be700?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2a7b61) will **increase** coverage by `0.01%`.
> The diff coverage is `98.11%`.
```diff
@@ Coverage Diff @@
## master #3223 +/- ##
============================================
+ Coverage 77.45% 77.47% +0.01%
Complexity 1439 1439
============================================
Files 1629 1629
Lines 43433 43399 -34
Branches 3654 3649 -5
============================================
- Hits 33643 33622 -21
+ Misses 8278 8267 -11
+ Partials 1512 1510 -2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/servicecomb/loadbalance/ServerListFilterExt.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmVyTGlzdEZpbHRlckV4dC5qYXZh) | `66.66% <0.00%> (+33.33%)` | :arrow_up: |
| [...cecomb/loadbalance/event/IsolationServerEvent.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZXZlbnQvSXNvbGF0aW9uU2VydmVyRXZlbnQuamF2YQ==) | `58.33% <ø> (ø)` | |
| [...oadbalance/filterext/IsolationDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyZXh0L0lzb2xhdGlvbkRpc2NvdmVyeUZpbHRlci5qYXZh) | `95.58% <100.00%> (ø)` | |
| [...oadbalance/filterext/ZoneAwareDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyZXh0L1pvbmVBd2FyZURpc2NvdmVyeUZpbHRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../apache/servicecomb/loadbalance/Configuration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvQ29uZmlndXJhdGlvbi5qYXZh) | `61.53% <0.00%> (-3.08%)` | :arrow_down: |
| [...he/servicecomb/foundation/common/net/NetUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9OZXRVdGlscy5qYXZh) | `64.80% <0.00%> (-1.61%)` | :arrow_down: |
| [...comb/loadbalance/ServiceCombLoadBalancerStats.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmljZUNvbWJMb2FkQmFsYW5jZXJTdGF0cy5qYXZh) | `82.43% <0.00%> (-1.36%)` | :arrow_down: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.63% <0.00%> (+1.06%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.31% <0.00%> (+1.14%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3223/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] etteeee commented on pull request #3223: [SCB-2643]fix instance isolation filter not work problem
Posted by GitBox <gi...@apache.org>.
etteeee commented on PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#issuecomment-1237632484
Now we have changed isolation and zoneaware type from `DiscoveryFilters` to `ServerListFilterEx`, so what is the real difference between this 2 types filter except for the filtering timing? What is the **RULE** when adding a new filter policy? @liubao68 @zhaozw
btw, it's better to create a new class with new name rather than moving to a new package, the class name may cause unnecessary confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#discussion_r929728134
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/FilterConstant.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.loadbalance;
+
+public interface FilterConstant {
+ int ORDER_NORMAL = 100;
+
+ int ORDER_ISOLATION = 0;
+
+ int ORDER_ZONE_AWARE = 200;
+
+ String EMPTY_INSTANCE_PROTECTION = "servicecomb.loadbalance.filter.isolation.emptyInstanceProtectionEnabled";
Review Comment:
Maybe can define these constants in ServerListFilterExt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#discussion_r929722704
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/FilterConstant.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.loadbalance;
+
+public interface FilterConstant {
+ int ORDER_NORMAL = 100;
Review Comment:
0
##########
handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/FilterConstant.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.loadbalance;
+
+public interface FilterConstant {
+ int ORDER_NORMAL = 100;
+
+ int ORDER_ISOLATION = 0;
Review Comment:
-100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
Posted by GitBox <gi...@apache.org>.
zhaozw closed pull request #3223: [#3208]IsolationDiscoveryFilter实例隔离的时候只更新了data，children如果已经缓存了，则不会更新，所以起不到隔离作用
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3223: [SCB-2643]fix instance isolation filter not work problem
Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3223:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3223#issuecomment-1237691678
@etteeee DiscoveryFilters may have better performance but can only be used when filter results not change only when instance lists changed, while ServerListFilterEx can be used for general purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org