You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2024/01/29 22:46:03 UTC
[I] Update variable properties for objects in package.json [daffodil-vscode]
shanedell opened a new issue, #955:
URL: https://github.com/apache/daffodil-vscode/issues/955
In the `package.json` we create different properties that can be used in the launch.json. However, for our object items we can defined that object properties as well. For example:
```json
"schema": {
"type": "object",
"description": "Contains the absolute path to the DFDL schema file, root element name and namespace.",
"default": {
"path": "${command:AskForSchemaName}",
"rootName": null,
"rootNamespace": null
}
},
```
should actually be:
```json
"schema": {
"type": "object",
"description": "Contains the absolute path to the DFDL schema file, root element name and namespace.",
"required": ["path"],
"properties": {
"path": {
"type": "string",
"description": "Absolute path to the DFDL schema file",
"default": "${command:AskForSchemaName}"
},
"rootName": {
"type": ["string", "null"],
"description": "Name of the root element",
"default": null
},
"rootNamespace": {
"type": ["string", "null"],
"description": "Name of the root element namespace",
"default": null
}
},
"default": {
"path": "${command:AskForSchemaName}",
"rootName": null,
"rootNamespace": null
}
},
```
- NOTE: This example is either fixed in or going to be fixed in PR https://github.com/apache/daffodil-vscode/pull/952. This issue will be for fixing all the other items
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919761280
@shanedell @nlewis05 would it be possible for there to just be a `<select>` that only holds valid enumerations defined from @nlewis05 's suggested edit?
**Changing:**
https://github.com/apache/daffodil-vscode/blob/776de38bf75bf01f3748ee0321319e392b3f4a2d/src/launchWizard/launchWizard.ts#L713
**To Be:**
```html
<select>
<option>Debug</option>
<option>Info</option>
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "nlewis05 (via GitHub)" <gi...@apache.org>.
nlewis05 commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919703591
Yea I think that may another issue, I'm not sure how that would look within the configuration, or if we already have framework to process that. To specify which specific module within the data editor or debugger, would that require a separate configuration for each module within the package.json? I think that would have to be handled from the module side.
https://github.com/apache/daffodil-vscode/blob/776de38bf75bf01f3748ee0321319e392b3f4a2d/package.json#L504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell closed issue #955: Update variable properties for objects in package.json
URL: https://github.com/apache/daffodil-vscode/issues/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919722743
@stricklandrbls @nlewis05 I am not sure what you mean, with the `enum` it will give the items supported but do you mean making sure nothing other than the options listed items in `enum` are used/entered? If so, that is something that would need to be handled in the TS code as I don't think that is something you can do directly inside of the `package.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919765237
For the launch wizard, yes doing something like you mention either a selection box or a dropdown would be good to have for the both the data editor and daffodil debugger logging level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919678260
@shanedell I would also like to see restricting of enumerated types. For instance, the log levels are strings that can be whatever the user inputs but in the extension a module might only support `info` `debug` or `warn` etc...
This may warrant another ticket though. Thoughts @nlewis05 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update variable properties for objects in package.json [daffodil-vscode]
Posted by "nlewis05 (via GitHub)" <gi...@apache.org>.
nlewis05 commented on issue #955:
URL: https://github.com/apache/daffodil-vscode/issues/955#issuecomment-1919752709
Yes, I believe that is what he is saying, and that was my concern as well that I stated above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org