You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/03/22 23:22:38 UTC
Review Request 45179: Support for overriding --mesos-root under
upstart.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45179/
-----------------------------------------------------------
Review request for Aurora and Stephan Erb.
Bugs: AURORA-1647
https://issues.apache.org/jira/browse/AURORA-1647
Repository: aurora-packaging
Description
-------
Previously only the sysv init script supported overriding `--mesos-root`
via an env var, and thus via `/etc/default/thermos`.
specs/debian/aurora-executor.thermos.upstart | 1 +
1 file changed, 1 insertion(+)
Diffs
-----
specs/debian/aurora-executor.thermos.upstart 7ebe4bea4debc9f558fae92c4d532145156ec43e
Diff: https://reviews.apache.org/r/45179/diff/
Testing
-------
Used this edit in testng done for https://reviews.apache.org/r/45167
Thanks,
John Sirois
Re: Review Request 45179: Support for overriding --mesos-root under
upstart.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45179/#review124910
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On March 22, 2016, 11:49 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45179/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 11:49 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Bugs: AURORA-1647
> https://issues.apache.org/jira/browse/AURORA-1647
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Previously only the sysv init script supported overriding `--mesos-root`
> via an env var, and thus via `/etc/default/thermos`.
>
> specs/debian/aurora-executor.thermos.upstart | 1 +
> 1 file changed, 1 insertion(+)
>
>
> Diffs
> -----
>
> specs/debian/aurora-executor.thermos.upstart 7ebe4bea4debc9f558fae92c4d532145156ec43e
>
> Diff: https://reviews.apache.org/r/45179/diff/
>
>
> Testing
> -------
>
> Used this edit in testing done for https://reviews.apache.org/r/45167
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 45179: Support for overriding --mesos-root under
upstart.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45179/
-----------------------------------------------------------
(Updated March 22, 2016, 4:49 p.m.)
Review request for Aurora and Stephan Erb.
Bugs: AURORA-1647
https://issues.apache.org/jira/browse/AURORA-1647
Repository: aurora-packaging
Description
-------
Previously only the sysv init script supported overriding `--mesos-root`
via an env var, and thus via `/etc/default/thermos`.
specs/debian/aurora-executor.thermos.upstart | 1 +
1 file changed, 1 insertion(+)
Diffs
-----
specs/debian/aurora-executor.thermos.upstart 7ebe4bea4debc9f558fae92c4d532145156ec43e
Diff: https://reviews.apache.org/r/45179/diff/
Testing (updated)
-------
Used this edit in testing done for https://reviews.apache.org/r/45167
Thanks,
John Sirois