You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/03/28 10:10:24 UTC
[kyuubi] branch master updated: [KYUUBI #4626] [UI][CI] Fix Web UI Ci check fail with pnpm the lockfile needs updates
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 6a7c57140 [KYUUBI #4626] [UI][CI] Fix Web UI Ci check fail with pnpm the lockfile needs updates
6a7c57140 is described below
commit 6a7c57140dfe86656cf5e235a8ef2d610ce6cd26
Author: zwangsheng <22...@qq.com>
AuthorDate: Tue Mar 28 18:10:14 2023 +0800
[KYUUBI #4626] [UI][CI] Fix Web UI Ci check fail with pnpm the lockfile needs updates
### _Why are the changes needed?_
After pnpm released 8.X version
We should specify pnpm version when npm install.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
- [x] CI with Web UI Build Check & Web UI Style Check
Closes #4626 from zwangsheng/fix/web_ui_ci.
Closes #4626
f7fdc0676 [Cheng Pan] Update .github/workflows/web-ui.yml
61bc10124 [Cheng Pan] Update .github/workflows/style.yml
7d9353218 [zwangsheng] Specify pnpm version
d678c6cb6 [zwangsheng] for feature version
6d83c2b01 [zwangsheng] revert
bbc4b4c2c [zwangsheng] Specify pnpm version
Lead-authored-by: zwangsheng <22...@qq.com>
Co-authored-by: Cheng Pan <pa...@gmail.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.github/workflows/style.yml | 2 +-
.github/workflows/web-ui.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml
index 040cdfb3e..2824e5972 100644
--- a/.github/workflows/style.yml
+++ b/.github/workflows/style.yml
@@ -93,7 +93,7 @@ jobs:
- name: Web UI Style with node
run: |
cd ./kyuubi-server/web-ui
- npm install pnpm -g
+ npm install pnpm@7 -g
pnpm install
pnpm run lint
echo "---------------------------------------Notice------------------------------------"
diff --git a/.github/workflows/web-ui.yml b/.github/workflows/web-ui.yml
index d99078990..2a48eeaa1 100644
--- a/.github/workflows/web-ui.yml
+++ b/.github/workflows/web-ui.yml
@@ -28,7 +28,7 @@ jobs:
- name: npm run coverage & build
run: |
cd ./kyuubi-server/web-ui
- npm install pnpm -g
+ npm install pnpm@7 -g
pnpm install
pnpm run coverage
pnpm run build