[GitHub] [bookkeeper] hsaputra commented on a change in pull request #2723: Refactor book keeper cluster test case

[GitBox <gi...@apache.org>]

hsaputra commented on a change in pull request #2723:
URL: https://github.com/apache/bookkeeper/pull/2723#discussion_r639971234



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -504,6 +504,12 @@ public boolean isSecure() {
         };
     }
 
+    public static String buildStatsLoggerScopeName(BookieId addr) {
+        StringBuilder nameBuilder = new StringBuilder();
+        nameBuilder.append(addr.toString().replace('.', '_').replace('-', '_').replace(":", "_"));

Review comment:
       Probably do not need StringBuilder for this.
   Just need to return `addr.toString().replace('.', '_').replace('-', '_').replace(":", "_")`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org