You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/12/17 16:31:03 UTC
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23799
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE and FE test that specifically test against beeswax port is adjusted
to either skip beeswax testing or re-enable the port by setting non-zero
flag value. EE and CustomCluster tests are modified to only test beeswax
if ENABLE_BEESWAX env var is 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests. Drop Beeswax option from perf-AB scripts (tests/performance/).
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
29 files changed, 168 insertions(+), 236 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/1
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21200/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 16:58:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#12) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
IMPALA-14990: Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
- Pass core tests with ENABLE_BEESWAX=true.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_server_tls.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
33 files changed, 242 insertions(+), 290 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/12
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 14: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 14
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 15 May 2026 21:40:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 6: Code-Review+1
This is looking good to me, assuming it passes precommit. Have we tried running with ENABLE_BEESWAX=true? (If that is passing, then let's add a sentence about that to the Testing section of the commit message.)
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:55:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 1:
(3 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py@319
PS1, Line 319: +
flake8: W504 line break after binary operator
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@658
PS1, Line 658: a
flake8: E501 line too long (96 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@666
PS1, Line 666: t
flake8: E501 line too long (93 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 16:35:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 18:16:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22311/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 18:12:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#10) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
IMPALA-14990: Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
- Pass core tests with ENABLE_BEESWAX=true.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_server_tls.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
33 files changed, 239 insertions(+), 290 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/10
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 14:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13502/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 14
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 15 May 2026 17:23:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 3:
Do we want to try and finish this?
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:43:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15
PS1, Line 15: test_beeswax.py is now moved from regular EE tests to CustomCluster
Please add a brief explanation for this move.
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc
File be/src/observe/otel-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203
PS1, Line 203: // EXPECT_FALSE(should_otel_trace_query("SELECT * FROM foo", TSessionType::BEESWAX));
I want to keep this test enabled. Queries submitted over the BEESWAX protocol do not have OTel traces generated for them, and this test enforces that.
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83
PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L);
This metric should be 0 even if beeswax is turned off. Thus, I think this assert makes sense to keep as-is.
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123
PS1, Line 123: }
Does it make sense to add an else clause that asserts beeswax_session_metric is still 0?
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100
PS1, Line 100: protocolsToTest = Arrays.asList("hs2", "hs2-http");
Should the ENABLE_BEESWAX environment variable be supported here?
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634
PS1, Line 634: protocolsToTest = Arrays.asList("hs2", "hs2-http");
Should the ENABLE_BEESWAX environment variable be supported here?
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40
PS1, Line 40: fix
Nit: "forces" would be a slightly more descriptive word to use here.
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: being
Nit: delete this word since beeswax is already deprecated.
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: validate
Nit: validates
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100
PS1, Line 100: This test only validate HiveServer2 implementation since Beeswax is being deprecated.
Same comments as line 43.
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129
PS1, Line 129: This test only validate HiveServer2 implementation since Beeswax is being deprecated.
Same comments as line 43.
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py
File tests/performance/query_executor.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125
PS1, Line 125: plugin_runner=plugin_runner
Is this a bug fix or was plugin_runner getting set another way? If it's a bug fix, please note it in the commit msg.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 17:48:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21209/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 22:45:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 13: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13493/
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 13
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 22:27:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22312/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 18:13:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22409/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 16:10:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13493/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 13
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 17:53:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 13
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 19:33:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13475/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 15:48:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
IMPALA-14990: Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
- Pass core tests with ENABLE_BEESWAX=true.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Reviewed-on: http://gerrit.cloudera.org:8080/23799
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_server_tls.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
33 files changed, 242 insertions(+), 290 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 15
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21208/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 22:03:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 14:
> Patch Set 14: Patch Set 13 was rebased
Encountered https://issues.apache.org/jira/browse/IMPALA-14992.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 14
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 15 May 2026 17:23:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22416/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 21:05:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 9: Code-Review+1
This is looking good to me. I'm +1'ing now, but if precommit passes and there are no other comments, I'll go to +2.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 18:56:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13475/
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 20:11:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13481/
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 01:17:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#9) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
IMPALA-14990: Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
- Pass core tests with ENABLE_BEESWAX=true.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
32 files changed, 236 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/9
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#4) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
32 files changed, 236 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/4
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#5) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
32 files changed, 235 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/5
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py
File tests/custom_cluster/test_kill_query.py:
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py@123
PS3, Line 123: "--ranger_app_id=impala --authorization_provider=ranger"
> These are custom cluster tests. Let's configure them to start with beeswax
Done
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 17:46:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 14: Code-Review+2
This looks good to me and passes test, so I think we can go ahead
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 14
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Fri, 15 May 2026 23:41:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22332/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Tue, 05 May 2026 18:14:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23799/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23799/3//COMMIT_MSG@25
PS3, Line 25: - Pass core tests.
Did you test that ENABLE_BEESWAX works as expected?
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py
File tests/custom_cluster/test_kill_query.py:
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py@123
PS3, Line 123: @SkipIf.no_beeswax
These are custom cluster tests. Let's configure them to start with beeswax enabled instead.
Is there a plan to rewrite the tests to use a different protocol? These are relatively recent tests.
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_otel_trace.py
File tests/custom_cluster/test_otel_trace.py:
http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_otel_trace.py@84
PS3, Line 84: @SkipIf.no_beeswax
This is a custom cluster test, so we could enable beeswax. I'm almost tempted to get rid of the test instead; there's a unit test that covers the same functionality. No strong feelings about changing anything here though.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Jan 2026 19:51:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23799
to look at the new patch set (#3).
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
31 files changed, 239 insertions(+), 287 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/3
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 3: Code-Review+1
(12 comments)
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15
PS1, Line 15:
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc
File be/src/observe/otel-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203
PS1, Line 203: if (FLAGS_beeswax_port > 0) {
> Changed to run it if besswax_port is open.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83
PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L);
> IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0.
Ack
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123
PS1, Line 123: }
> IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0.
Ack
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100
PS1, Line 100: protocolsToTest.add("beeswax");
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634
PS1, Line 634: }
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40
PS1, Line 40: for
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: validate
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: depr
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100
PS1, Line 100:
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129
PS1, Line 129:
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py
File tests/performance/query_executor.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125
PS1, Line 125: plugin_runner=plugin_runner
> It is a bug. plugin_runner parameter in __init__ method was unused before t
Ack
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 22:52:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 2:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15
PS1, Line 15: start_args. Drop Beeswax option from perf-AB
> Please add a brief explanation for this move.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc
File be/src/observe/otel-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203
PS1, Line 203: if (FLAGS_beeswax_port > 0) {
> I want to keep this test enabled. Queries submitted over the BEESWAX proto
Changed to run it if besswax_port is open.
http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py@319
PS1, Line 319:
> flake8: W504 line break after binary operator
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100
PS1, Line 100: protocolsToTest.add("beeswax");
> Should the ENABLE_BEESWAX environment variable be supported here?
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java:
http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634
PS1, Line 634: }
> Should the ENABLE_BEESWAX environment variable be supported here?
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@658
PS1, Line 658:
> flake8: E501 line too long (96 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@666
PS1, Line 666:
> flake8: E501 line too long (93 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40
PS1, Line 40: for
> Nit: "forces" would be a slightly more descriptive word to use here.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: depr
> Nit: delete this word since beeswax is already deprecated.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43
PS1, Line 43: validate
> Nit: validates
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100
PS1, Line 100:
> Same comments as line 43.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129
PS1, Line 129:
> Same comments as line 43.
Done
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py
File tests/performance/query_executor.py:
http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125
PS1, Line 125: plugin_runner=plugin_runner
> Is this a bug fix or was plugin_runner getting set another way? If it's a
It is a bug. plugin_runner parameter in __init__ method was unused before this change. But I suspect it always None anyway, so there is no effect (see "--plugin_names" param in bin/run-workload.py).
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 21:40:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 4:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23799/4/tests/custom_cluster/test_kill_query.py
File tests/custom_cluster/test_kill_query.py:
http://gerrit.cloudera.org:8080/#/c/23799/4/tests/custom_cluster/test_kill_query.py@24
PS4, Line 24: from tests.common.skip import SkipIf
flake8: F401 'tests.common.skip.SkipIf' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2026 17:47:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#7) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
- Pass core tests with ENABLE_BEESWAX=true.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
32 files changed, 236 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/7
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc
File be/src/service/session-expiry-test.cc:
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83
PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L);
> This metric should be 0 even if beeswax is turned off. Thus, I think this
IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0.
http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123
PS1, Line 123: }
> Does it make sense to add an else clause that asserts beeswax_session_metri
IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 22:07:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23799
to look at the new patch set (#2).
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
29 files changed, 225 insertions(+), 277 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/2
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13917 (part 2): Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#6) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default
......................................................................
IMPALA-13917 (part 2): Close Beeswax port by default
This patch close beeswax port by setting the beeswax_port=0 by default.
BE, EE, and CustomCluster tests are modified to only test beeswax if
ENABLE_BEESWAX env var is 'true' (or beeswax_port > 0).
Skip checking impala-server.num-open-beeswax-sessions in
metric_verifier.py if ENABLE_BEESWAX is not 'true'.
test_beeswax.py is now moved from regular EE tests to CustomCluster
tests because running it will require passing --enable_beeswax flag as
start_args. Drop Beeswax option from perf-AB
scripts (tests/performance/), and fix unused pluggin_runner arg bug in
HiveHS2QueryConfig.
Also fixed various flake8 issues in modified python files.
Testing:
- Pass core tests.
Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
---
M be/src/observe/otel-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/service/impala-server.cc
M be/src/service/internal-server-test.cc
M be/src/service/session-expiry-test.cc
M bin/run-workload.py
M bin/start-impala-cluster.py
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java
M tests/common/cluster_config.py
M tests/common/environ.py
M tests/common/impala_cluster.py
M tests/common/impala_test_suite.py
M tests/common/skip.py
M tests/common/test_dimensions.py
R tests/custom_cluster/test_beeswax.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_kill_query.py
M tests/custom_cluster/test_kudu.py
M tests/custom_cluster/test_otel_trace.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_session_expiration.py
M tests/custom_cluster/test_set_and_unset.py
M tests/custom_cluster/test_shell_interactive_reconnect.py
M tests/performance/query_exec_functions.py
M tests/performance/query_executor.py
M tests/performance/workload_runner.py
M tests/shell/test_shell_commandline_jwt_auth.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
M tests/verifiers/metric_verifier.py
32 files changed, 236 insertions(+), 289 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/23799/6
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 11: Code-Review+1
The change to test_server_tls.py looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 20:45:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13481/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 20:44:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 9:
> Patch Set 8: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13475/
Looks like some new tests expect beeswax. I'll fix them up.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 20:24:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14990: Close Beeswax port by default
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-14990: Close Beeswax port by default
......................................................................
Patch Set 11:
> Patch Set 11: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13481/
Ah, dockerized tests also fail during container setup.
--
To view, visit http://gerrit.cloudera.org:8080/23799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd
Gerrit-Change-Number: 23799
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Comment-Date: Thu, 14 May 2026 15:22:54 +0000
Gerrit-HasComments: No