[GitHub] [incubator-devlake] chenggui53 commented on pull request #4896: refactor: add subtask register

["chenggui53 (via GitHub)" <gi...@apache.org>]

chenggui53 commented on PR #4896:
URL: https://github.com/apache/incubator-devlake/pull/4896#issuecomment-1576712690

   > Looking good! Good job. Is it ready yet?
   
   hi @klesh, sorry for taking so long, can you help to review this pr when you have time? It mainly includes the following content (to avoid a large number of modifications in each plugin, first only modify the gitlab plugin, and then apply it to other plugins after the code is ok)
   
   in backend/core
   1. Add the subTaskMetas dependencies field in the subTaskMeta structure
   
   in backend/plugin
   1. Stable topological sorting algorithm and loop detection
   2. The sort interface can be extended to entity-level sorting in the future. Currently, only subtask-level sorting is implemented
   
   In backend/plugins/gitlab, take gitlab as an example
   1. In the impl.go file, loop detection will be performed during package init
   2. Add dependencies definition to each subTaskMeta
   2. Each subtask adds an init function for registration
   3. Added the register.go file to register subtask, and added tests to ensure compliance with the tone


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org