You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/07/08 07:55:38 UTC
[GitHub] [skywalking] dmsolr commented on a change in pull request #3021:
Using ArryList instead of LinkedList
dmsolr commented on a change in pull request #3021: Using ArryList instead of LinkedList
URL: https://github.com/apache/skywalking/pull/3021#discussion_r300964080
##########
File path: apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/consumer/ConsumerThread.java
##########
@@ -36,7 +37,7 @@
super(threadName);
this.consumer = consumer;
running = false;
- dataSources = new LinkedList<DataSource>();
+ dataSources = new ArrayList<DataSource>(1);
Review comment:
Because I think the default value(10) is large. It will only grow at initialization. Could you give some suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services