Re: svn commit: rev 2213 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client trunk/subversion/bindings/ruby trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline

[Karl Fogel <kf...@newton.ch.collab.net>]

Okay, the relevant part of the notification system rewrite is merged
into trunk now, and I'm back on issue #517 (modules).

And I'd like to say a public Thank You to Greg Stein for his red-flag
mail suggesting that this would be more manageable in pieces.  I mean,
it's embarrassing enough to not notice that one is going too far down
the wrong road -- but it's downright humbling when someone else *does*
notice from 2500 miles away!  Good call, Greg :-).

-K


kfogel@tigris.org writes:
> Log:
> Merge notification system changes from the issue-662-dev branch:
> 
>  svn merge -r2198:2212 http://svn.collab.net/repos/svn/branches/issue-662-dev
> 
> Plus the following post-merge changes:
> 
> * subversion/tests/clients/cmdline/update_tests.py
>   (update_delete_modified_files): Pass 'log msg' as the commit message,
>   not 'foo'.  Otherwise, if you happen to have a file `foo' lying
>   around, svn ci complains that the log message is a pathname :-).
> 
> * subversion/tests/clients/cmdline/switch_tests.py: Set the
>   svn:executable property on this file.
>   (commit_routine_switching): Same 'log msg' change as above.
> 
> 
> This resolves enough of issue #662 to allow us to finish issue #517
> (module system).  
> 
> To help understand what's left to do for issue #662, here's a
> chronology of the issue-662-dev branch:
> 
>    2198 -- Created branches/issue-662-dev/, based on trunk/
> 
>    2199 -- Commited an almost-complete rewrite of the notification
>            system, making most things use a notify callback instead of
>            trace editor.  The only thing left using a trace editor
>            after this is `svn merge'.  However, the branch no longer
>            passes "make check" after this, due to various differences
>            between the old trace output and the new notification
>            output.
> 
>    2202 -- Reverted the changes to the commit/copy/import/ system, as
>            that portion of 2199 was causing most of the test suite
>            failures.  After this, only a few tests still fail.
>    
>    2212 -- Made the remaining tests pass, but by fixing bugs this
>            time, not by more reversions.
> 
> So the recipe to finish issue #662 is pretty simple, now that we've
> merged the above changes into trunk.  First, undo the reversions of
> 2202 (but undo them in trunk, not the branch!), see what still fails,
> and fix it.  Then rewrite the merge/diff editors to use notification
> instead of trace, and get rid of the old trace editor code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org