[GitHub] [spark] attilapiros commented on a change in pull request #31877: [SPARK-34783][K8S] Support remote template files

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #31877:
URL: https://github.com/apache/spark/pull/31877#discussion_r596831803



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesUtilsSuite.scala
##########
@@ -65,4 +65,14 @@ class KubernetesUtilsSuite extends SparkFunSuite {
     assert(sparkPodWithNoContainerName.pod.getSpec.getHostname == HOST)
     assert(sparkPodWithNoContainerName.container.getName == null)
   }
+
+  test("SPARK-34783 Support remote template files") {
+    Seq(
+      getClass.getClassLoader.getResource("template-file.yaml").getFile,
+      "https://raw.githubusercontent.com/apache/spark/master/resource-managers/kubernetes/" +

Review comment:
       I have some concern regarding this test. 
   
   Not only because this test will depend on the internet connection but more because here we are connecting the "master" branch which is moving part with a checked in code which is a non-moving (after releasing it). 
   So if we check this in and we will have Spark4 where just the project structure is changed or the the filename we make the "old" Spark3 test fail. 
   
   I think it would good to avoid such dependencies.
   
   I am surprised we have not got a jetty based 
   ```
   withHttpServer(files) {
   }
   ```
   construct, which uses a Jetty `ResourceHandler` to serve the listed files (or directories/just the root where it is started from) and stops the server at the finally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org