[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6244: kvm: truncate vnc password to 8 chars

[GitBox <gi...@apache.org>]

weizhouapache commented on code in PR #6244:
URL: https://github.com/apache/cloudstack/pull/6244#discussion_r848257086


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1764,7 +1764,7 @@ public String toString() {
                 graphicBuilder.append(" listen=''");
             }
             if (_passwd != null) {
-                graphicBuilder.append(" passwd='" + _passwd + "'");
+                graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");

Review Comment:
   @rohityadavcloud 
   this aims to fix an issue with ubuntu 22.04 (to be released soon) and libvirt 8.
   the issue is raised in mailing list: https://lists.apache.org/thread/zk4fyggjqk1zphk4dfg1m596yrd15d9b
   
   from many years ago, libvirt accepts vnc password with more than 8 chars. but only the first 8 chars in vnc password are used in vnc console verification (the other chars are dropped).
   In recent libvirt, only vnc password with 8 chars is permitted.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org