You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/05 10:21:11 UTC
[jira] [Commented] (HAWQ-888) Remove some dummy files which were
used to keep related "empty" directories.
[ https://issues.apache.org/jira/browse/HAWQ-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362329#comment-15362329 ]
ASF GitHub Bot commented on HAWQ-888:
-------------------------------------
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/773
HAWQ-888. Remove some dummy files which were used to keep related "em…
…pty" directories.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq make
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/773.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #773
----
commit 4eda5a6f127ae65f753a8d4f217ef456cad01a6e
Author: Paul Guo <pa...@gmail.com>
Date: 2016-07-05T10:16:17Z
HAWQ-888. Remove some dummy files which were used to keep related "empty" directories.
----
> Remove some dummy files which were used to keep related "empty" directories.
> ----------------------------------------------------------------------------
>
> Key: HAWQ-888
> URL: https://issues.apache.org/jira/browse/HAWQ-888
> Project: Apache HAWQ
> Issue Type: Bug
> Components: Build
> Reporter: Paul Guo
> Assignee: Paul Guo
>
> After building with pgcrypto, plr, orca, the git repos will have the following tracked files.
> Changes not staged for commit:
> (use "git add/rm <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
> deleted: gp-xerces/git_keep_empty_directory.readme
> deleted: gporca/git_keep_empty_directory.readme
> deleted: gpos/git_keep_empty_directory.readme
> deleted: postgres/git_keep_empty_directory.readme
> deleted: ../../src/pl/plr/git_keep_empty_directory.readme
> Those files are just to remind developers to not write the directory (git does not save empty directories). This is really annoying. .gitignore does not resolve this issue.
> A simple and elegant solution is:
> git update-index --assume-unchanged
> however followering error is seen after parallel building,
> fatal: Unable to create '/data2/github/incubator-hawq/.git/index.lock': File exists.
> If no other git process is currently running, this probably means a
> git process crashed in this repository earlier. Make sure no other git
> process is running and remove the file manually to continue.
> I do not want to waste too much time in digging into git internals, instead,
> I'd try another simple solution:
> - rm -f git_keep_empty_directory.readme; \
> + mv -f gporca.git_keep_empty_directory.readme ..; \
> [ ! -d .git ] && git clone $(gporca_git) . && git checkout $(gporca_branch); \
> + mv -f ../gporca.git_keep_empty_directory.readme .; \
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)