You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/19 08:56:49 UTC
[GitHub] [skywalking-php] jmjoy opened a new pull request, #46: Report instance properties and keep alive.
jmjoy opened a new pull request, #46:
URL: https://github.com/apache/skywalking-php/pull/46
1. Report instance properties and keep alive.
2. Clearly limit the version of Skywalking (>= 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng merged pull request #46: Report instance properties and keep alive.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #46:
URL: https://github.com/apache/skywalking-php/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng commented on pull request #46: Report instance properties and keep alive.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397755751
Yes, you are correct. I totally forgot this. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] Superskyyy commented on pull request #46: Report instance properties and keep alive.
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397797583
> Yes, you are correct. I totally forgot this. 😅
😄 @jmjoy FYI the instance property will require a periodical update.
Refer to Java agent here:
https://github.dev/apache/skywalking-java/blob/f366503d58aa7e3395d88f6c70e6ea885fc50d2e/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/ServiceManagementClient.java#L105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] Superskyyy commented on pull request #46: Report instance properties and keep alive.
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397591193
I just saw this and remembered agents were supposed to resubmit instance properties periodically as the OAP TTL mechanism would purge them. Is it still true? @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org